This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Image): 'fluid' variant and size variables#54
Merged
Conversation
mnajdova
approved these changes
Aug 7, 2018
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 87.39% 87.36% -0.03%
==========================================
Files 74 74
Lines 1150 1148 -2
Branches 215 207 -8
==========================================
- Hits 1005 1003 -2
Misses 141 141
Partials 4 4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image
The necessary functionality for customizing size of Image component has been introduced.
TODO
API Proposal
Fluid
Make parent's width to be a width of the Image component.
'width' and 'height' variables
These could be used to precisely set
widthandheightof the Image.