This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icons): mark Processed Icons moved to Teams theme#574
Merged
Conversation
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
changed the title
levithomason
reviewed
Dec 7, 2018
levithomason
reviewed
Dec 7, 2018
levithomason
reviewed
Dec 7, 2018
levithomason
reviewed
Dec 7, 2018
kuzhelov
added
needs author feedback
kuzhelov
added
🚀 ready for review
and removed
needs author feedback
levithomason
approved these changes
Dec 7, 2018
…hub.com/stardust-ui/react into feat/mark-teams-icons-moved-to-stardust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces necessary mapping for Processed Icons that will be exported by Teams theme. This will help to address the following concerns:
TODO
How it will look like
With Filtering
Review hint
Changes provided in
icons-*files are only about introducing type correctness - and those are identical for each of theseicons-*.