This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(getKeyDownHandler): Pass props to client's "onKeyDown" handler#595
Merged
fix(getKeyDownHandler): Pass props to client's "onKeyDown" handler#595
Conversation
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
…nHandlers-pass-props' of https://github.com/stardust-ui/react into fix/getKeyDownHandlers-pass-props # Conflicts: # CHANGELOG.md
mnajdova
reviewed
Dec 11, 2018
| @@ -42,7 +42,7 @@ const getKeyDownHandlers = ( | |||
| eventHandler && eventHandler(event) | |||
Contributor
There was a problem hiding this comment.
Do we want to add the props to the eventHandler as well? We can define then the actions in the following manner:
protected actionHandlers: AccessibilityActionHandlers = {
performClick: (event, props) => this.handleClick(event, props),
}
Not sure, if the previous definition with the event is necessary:
protected actionHandlers: AccessibilityActionHandlers = {
performClick: event => this.handleClick(event),
}
because the event is send in the getKeyDownHandler, I don't see why we cannot send the props too. Let me know if this works and make sense (it makes sense in my opinion, as we would have unified way of defining the handlers).
Contributor
There was a problem hiding this comment.
Disregard my comment, I was mixing it with other problems. The changes for this PR are sufficient 👍
mnajdova
reviewed
Dec 11, 2018
Contributor
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
Please take a look into my comment. It would be great if we can add this too.
mnajdova
approved these changes
Dec 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.