This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): ensure popup is closing on outside click#598
Merged
Conversation
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
miroslavstastny
approved these changes
Dec 12, 2018
Member
miroslavstastny
left a comment
miroslavstastny
left a comment
There was a problem hiding this comment.
This fixes the issue with MenuItem being the trigger for popup.
It still does not work for nested popup (no regression) - https://codesandbox.io/s/wk5vvw56pw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue is described here: #557
TODO
Root cause
The cause of the problem is the fact that
Menucomponent "intercepts" click event, so thatPopupis unaware of whether this event has happened or not.Fix
useCaptureevent interception logic is now used forPopupevent subscriptions - this will guarantee that event won't pass unnoticed.