This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icons): added icon for table-add and table-delete#643
Merged
kuzhelov merged 5 commits intomicrosoft:masterfrom Dec 19, 2018
Merged
feat(Icons): added icon for table-add and table-delete#643kuzhelov merged 5 commits intomicrosoft:masterfrom
kuzhelov merged 5 commits intomicrosoft:masterfrom
Conversation
Contributor
VyshnaviDasari
commented
Dec 19, 2018
VyshnaviDasari
commented
- Added table-add and table-delete
VyshnaviDasari
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
alinais
approved these changes
Dec 19, 2018
mnajdova
reviewed
Dec 19, 2018
CHANGELOG.md
Outdated
| - Add `sizeModifier` variable (with `x` and `xx` values) to `Icon`'s Teams theme styles @priyankar205 ([#601](https://github.com/stardust-ui/react/pull/601)) | ||
| - Add `offset` prop to `Popup` to extend set of popup positioning options @kuzhelov ([#606](https://github.com/stardust-ui/react/pull/606)) | ||
| - Export `table-add` SVG icon @VyshnaviDasari ([#643](https://github.com/stardust-ui/react/pull/643)) | ||
| - Export `table-delete` SVG icon @VyshnaviDasari ([#643](https://github.com/stardust-ui/react/pull/643)) |
Contributor
There was a problem hiding this comment.
- Export `table-add` SVG icon @VyshnaviDasari ([#643](https://github.com/stardust-ui/react/pull/643))
- Export `table-delete` SVG icon @VyshnaviDasari ([#643](https://github.com/stardust-ui/react/pull/643))
->
- Export `table-add` and `table-delete` SVG icon in Teams theme @VyshnaviDasari ([#643](https://github.com/stardust-ui/react/pull/643))
We want to have one item in the changelog for one PR, and we should mention Teams theme if we are adding changes only for this theme.
mnajdova
approved these changes
Dec 19, 2018
kuzhelov
suggested changes
Dec 19, 2018
Contributor
kuzhelov
left a comment
kuzhelov
left a comment
There was a problem hiding this comment.
note that this PR will be merged to the forked repo. Let me add you to collaborators group, so that you'll be able to push changes to Stardust repo directly (probably, it will require to recreate the PR)
Contributor
Author
|
@kuzhelov May I know what's the problem with this PR? Why can't it be directly merged ? |
bmdalex
approved these changes
Dec 19, 2018
kuzhelov
approved these changes
Dec 19, 2018
kuzhelov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.