This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Merged
Conversation
luzhon
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
mnajdova
as code owners
levithomason
suggested changes
Aug 8, 2018
Member
levithomason
left a comment
levithomason
left a comment
There was a problem hiding this comment.
Let's add a CHANGELOG.md entry for this. Perhaps under the Fix heading? Instructions are in the file.
…t-ui/react into feat/luzhon/typescript-3
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
======================================
Coverage 85.9% 85.9%
======================================
Files 74 74
Lines 1100 1100
Branches 225 225
======================================
Hits 945 945
Misses 149 149
Partials 6 6Continue to review full report at Codecov.
|
Contributor
Author
|
@levithomason addressed your review |
levithomason
approved these changes
Aug 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to Typescript 3.0