This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): update positions after each render#678
Merged
layershifter merged 3 commits intomasterfrom Jan 9, 2019
Merged
Conversation
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
Jan 3, 2019
| "react-dom": "^16.3.0" | ||
| }, | ||
| "resolutions": { | ||
| "create-react-context": "0.2.2" |
Member
Author
There was a problem hiding this comment.
react-popper now defines max version of create-react-context
https://github.com/FezVrasta/react-popper/releases/tag/v1.3.1
miroslavstastny
approved these changes
Jan 9, 2019
…b.com/stardust-ui/react into fix/popup-force-update # Conflicts: # CHANGELOG.md
Contributor
|
unfortunately, there is another problem introduced by this fix - now an infinite render loop starts on Popup open. In fact, we just need to force position update on async operation finish. I would suggest (as a very base step) to stick to the same strategy used by Popper - i.e. let the client explicitly decide when this update should be made.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #641.