This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Header): introduce 'color' variable#72
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 85.89% 85.97% +0.07%
==========================================
Files 74 76 +2
Lines 1106 1112 +6
Branches 219 228 +9
==========================================
+ Hits 950 956 +6
Misses 149 149
Partials 7 7
Continue to review full report at Codecov.
|
mnajdova
reviewed
Aug 9, 2018
| textAlign: PropTypes.oneOf(['left', 'center', 'right', 'justified']), | ||
|
|
||
| /** Custom values for styling variables. */ | ||
| variables: PropTypes.object, |
Contributor
There was a problem hiding this comment.
Is it necessary to add the variables prop? We don't have it added in any of the other components.
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Got it! We should address this in the other components as well. Approving this PR.
mnajdova
approved these changes
Aug 9, 2018
…er-and-description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Header color
Introduce
colorproperty toHeaderandHeader.DescriptionTODO
API Proposal
Header - color (variable)
Defines color of
Header.Header.Description - color (variable)
Defines color of header's description (Header.Description).