This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(typings): import in d.ts files#76
Merged
levithomason merged 4 commits intomasterfrom Aug 13, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 39 39
Lines 664 664
Branches 90 99 +9
=======================================
Hits 573 573
Misses 88 88
Partials 3 3
Continue to review full report at Codecov.
|
Member
|
Heads up, I've merged master and fixed conflicts here for you |
| | undefined | ||
|
|
||
| export type ComponentPartStyle = ComponentPartStyleFunction | ICSSInJSStyle | ||
| export type ComponentPartStyle = ComponentPartStyleFunction | ICSSInJSStyle | undefined |
Member
There was a problem hiding this comment.
I'm still not sure this is required. This doesn't exist on master yet typings compile, tests pass, and all functionality is working.
Could you recap why we need this again?
Collaborator
Author
levithomason
approved these changes
Aug 13, 2018
Member
|
Approved, merged master, added changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Generated definition files (d.ts) contain an incorrect path to import some of the types if they are used implicitly on static properties. To avoid this, we have to declare types explicitly.
This PR adds the types explicitly.