Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(Accordion): panel title layout#780

Merged
kuzhelov merged 6 commits intomasterfrom
fix/accordion-panel-title-layout
Jan 28, 2019
Merged

fix(Accordion): panel title layout#780
kuzhelov merged 6 commits intomasterfrom
fix/accordion-panel-title-layout

Conversation

@kuzhelov
Copy link
Contributor

@kuzhelov kuzhelov commented Jan 28, 2019

TODO

  • add docs example
  • add changelog entry

This PR removes empty line rendered for Accordion panel's title whenever custom block element was introduced:

const panels = [
  {
    title: { content: <div>What is a point?</div> },
    content: ...
  },
  ...
]

export default () => <Accordion panels={panels} />

Was

image

Now

image

<>
{Indicator.create(indicatorWithDefaults, {
<Layout
start={Indicator.create(indicatorWithDefaults, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is worth adding example so the screens will catch this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, was thinking about the same thing, was waiting for the same opinions on that :) will add, thank you!

@kuzhelov kuzhelov added the 🧰 fix Introduces fix for broken behavior. label Jan 28, 2019
@kuzhelov kuzhelov merged commit 0b3cbfc into master Jan 28, 2019
@layershifter layershifter deleted the fix/accordion-panel-title-layout branch January 29, 2019 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

🧰 fix Introduces fix for broken behavior. 🚀 ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants