This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Animation): support keyframes as functions and add keyframeParams prop#794
Merged
feat(Animation): support keyframes as functions and add keyframeParams prop#794
Conversation
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
mnajdova
changed the title
kuzhelov
reviewed
Jan 30, 2019
docs/src/examples/components/Animation/Types/AnimationExampleKeyframeParams.tsx
Outdated
Show resolved
Hide resolved
kuzhelov
reviewed
Jan 30, 2019
Member
miroslavstastny
left a comment
miroslavstastny
left a comment
There was a problem hiding this comment.
Technically it is obvious, but shouldn't we document anywhere that each unique keyframeParams will render as a new @keyframes?
Contributor
Author
|
@miroslavstastny that's a great point. Will add info in the examples of the keyframeParams that new keyframe will be added if the params are changed.. |
added 3 commits
January 30, 2019 16:49
-merged keyframe params
# Conflicts: # CHANGELOG.md
miroslavstastny
approved these changes
Jan 30, 2019
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds keyframeParams in the definition of the animations. Also, keyframes now can be defined as functions, that will receive the keyframeParams defined in the animation itself or as a prop from the user. There is an example of the usage added as part of the PR. This fixes #760