This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(menu): Padding variables for horizontal menu#808
Merged
jurokapsiar merged 3 commits intomasterfrom Jan 31, 2019
Merged
Conversation
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
alinais
approved these changes
Jan 31, 2019
| horizontalPaddingLeft: pxToRem(18), | ||
| horizontalPaddingRight: pxToRem(18), | ||
| horizontalPaddingTop: pxToRem(14), | ||
| horizontalPaddingBottom: pxToRem(14), |
Member
There was a problem hiding this comment.
When four values are specified, the paddings apply to the top, right, bottom, and left in that order (clockwise).
https://developer.mozilla.org/en-US/docs/Web/CSS/padding#Values
My vote is to keep a single value:
Suggested change
| horizontalPaddingBottom: pxToRem(14), | |
| horizontalPadding: `${pxToRem(14)} ${pxToRem(18)} ${pxToRem(14)} ${pxToRem(18)}` |
jurokapsiar
added
🚀 ready for review
and removed
help wanted
layershifter
approved these changes
Jan 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumer needs to be able to customize padding in the menu. This PR adds variables that allow to do this for the vertical variant.
I'm not sure if this is the right API as the variable names are bound to the variant (horizontal), so any feedback would be appreciated