This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Accessibility): Accessibility for menu divider#822
Merged
jurokapsiar merged 6 commits intomasterfrom Feb 1, 2019
Merged
Conversation
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
mnajdova
approved these changes
Feb 1, 2019
Contributor
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
LGTM, just update the changelog.
layershifter
reviewed
Feb 1, 2019
layershifter
reviewed
Feb 1, 2019
| role: 'presentation', | ||
| }, | ||
| }, | ||
| }) |
Member
There was a problem hiding this comment.
A little confused with this, we don't have a behavior for Divider. How are they differenced?
Contributor
Author
There was a problem hiding this comment.
it's just that we did not get to divider yet. it will be done soon. If it turns out to be the same, we will consolidate.
Contributor
There was a problem hiding this comment.
The MenuDivider is part of the list (it is li) element and I guess as the other elements in the menu has this role.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds accessibility behavior to the menu divider