This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(dropdown): fixed dropdown style regression#824
Merged
Conversation
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
bmdalex
force-pushed
the
fix/dropdown-style-regression
branch
from
0fbcd13 to
d5b2fa7
Compare
mnajdova
approved these changes
Feb 1, 2019
bmdalex
force-pushed
the
fix/dropdown-style-regression
branch
2 times, most recently
from
1f2290e to
48ed84d
Compare
Codecov Report
@@ Coverage Diff @@
## master #824 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 69 73 +4
=======================================
Hits 681 681
Misses 47 47Continue to review full report at Codecov.
|
- height should be 32px for Dropdown and Input - width of trigger button and input (they should stretch to 100% of parent)
bmdalex
force-pushed
the
fix/dropdown-style-regression
branch
from
6fa29c0 to
3264e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(dropdown): fixed dropdown style regression