This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(gridBehavior): changing the focus zone to embed#844
Merged
Conversation
kolaps33
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
jurokapsiar
approved these changes
Feb 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #844 +/- ##
==========================================
- Coverage 93.54% 92.99% -0.55%
==========================================
Files 21 21
Lines 728 728
Branches 73 73
==========================================
- Hits 681 677 -4
- Misses 47 51 +4
Continue to review full report at Codecov.
|
layershifter
approved these changes
Feb 8, 2019
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
Please a changelog entry 📝
sophieH29
reviewed
Feb 11, 2019
|
|
||
| ### Fixes | ||
| - Focus the last focused element which triggered `Popup` on ESC @sophieH29 ([#861](https://github.com/stardust-ui/react/pull/861)) | ||
| - Changing the focus zone to embed for gridBehavior @kolaps33 ([#844] (https://github.com/stardust-ui/react/pull/844)) |
Contributor
There was a problem hiding this comment.
A small improvement
Changing the FocusZone's mode to Embed in gridBehavior
sophieH29
approved these changes
Feb 11, 2019
This was referenced Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recognized that additional 'div' wrapper from focus zone was Firefox presented in accessibility DOM as focusable section.
Then for example NVDA navigated to the section and was narrating whole content of the 'div'.
Therefore changing the focus sone to 'embed'