Conversation
docs/src/examples/components/Dropdown/Types/DropdownExampleMultipleSelection.shorthand.tsx
Outdated
Show resolved
Hide resolved
docs/src/examples/components/Dropdown/Types/DropdownExampleMultipleSelection.shorthand.tsx
Outdated
Show resolved
Hide resolved
a52bbea to
472c222
Compare
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 69 73 +4
=======================================
Hits 681 681
Misses 47 47Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 73 73
=======================================
Hits 681 681
Misses 47 47Continue to review full report at Codecov.
|
b53d0d9 to
4701332
Compare
docs/src/examples/components/Dropdown/Types/DropdownExampleMultipleSelection.shorthand.steps.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
why do we need that parameter if we can get it from state as we did with the props? this method might as well be getTriggerButtonMessage or getTriggerButtonText. not important but was just curious why not like that. oh, and capital I in If there is no value...
There was a problem hiding this comment.
this method is also used here, but not merged yet:
https://github.com/stardust-ui/react/pull/839/files#r254290634
with a different parameter, so the proposed name would not apply anymore, open to other naming suggestions
Will add capital "I", thanks
4701332 to
581688e
Compare
581688e to
604ccd5
Compare
feat(dropdown): multiple selection
Description:
This PR implements the multiple selection with trigger button flavor for
Dropdowncomponent (easy to leverage existing functionality)API
renders:
