This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Merged
Conversation
kolaps33
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
==========================================
+ Coverage 80.37% 80.38% +0.01%
==========================================
Files 656 657 +1
Lines 8393 8398 +5
Branches 1488 1424 -64
==========================================
+ Hits 6746 6751 +5
Misses 1632 1632
Partials 15 15
Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
Feb 11, 2019
| * @specification | ||
| * Adds role='img'. | ||
| */ | ||
|
|
Member
There was a problem hiding this comment.
Should be there an empty line? 🤔
layershifter
approved these changes
Feb 14, 2019
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
Please also add a changelog entry 👍
| /** | ||
| * A status graphically represents someone's or something's state. | ||
| * @accessibility | ||
| * Don't forget to put appropriate 'alt' attribute describing status. This is necessary for correct screen reader behavior. |
Member
There was a problem hiding this comment.
If alt prop is so necessary, should be a component prop?
…m/stardust-ui/react into mituron/status-screen-reader-mode
miroslavstastny
approved these changes
Feb 19, 2019
delete-merged-branch
bot
deleted the
mituron/status-screen-reader-mode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recognized if status is used in context then the status itself is not navigable with screen reader in the reader mode (like virtual cursor, scan mode, browse mode).
Se we need to put status as img with proper alt attribute. Then the reader navigate on the status element in reader mode.