This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(pxToRem): update rem size on static styles render#883
Merged
Conversation
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 21 21
Lines 728 728
Branches 73 69 -4
=======================================
Hits 677 677
Misses 51 51Continue to review full report at Codecov.
|
kuzhelov
added
🧰 fix
layershifter
approved these changes
Feb 12, 2019
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
Let's go with this to fix the issue and try to get a better solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
This PR introduces logic that is necessary to update base rem value of
pxToRemutility (that was previously cached forever on page load) once newly loaded theme is applying static styles.This PR leaves it to be a separate discussion whether static styles should be allowed for Stardust themes - the sole purpose of these changes is to address the problem of page font size updates after theme load that we currently have.