This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dropdown): inserting char at a cursor position will the cursor to end#897
Merged
layershifter merged 2 commits intomasterfrom Feb 14, 2019
Merged
fix(Dropdown): inserting char at a cursor position will the cursor to end#897layershifter merged 2 commits intomasterfrom
layershifter merged 2 commits intomasterfrom
Conversation
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #897 +/- ##
==========================================
+ Coverage 80.57% 80.59% +0.02%
==========================================
Files 648 648
Lines 8335 8334 -1
Branches 1485 1484 -1
==========================================
+ Hits 6716 6717 +1
+ Misses 1604 1602 -2
Partials 15 15
Continue to review full report at Codecov.
|
silviuaavram
approved these changes
Feb 14, 2019
Collaborator
silviuaavram
left a comment
silviuaavram
left a comment
There was a problem hiding this comment.
like a charm. thanks a bunch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #865.
It's a known issue in
Downshift, see:Before
After