This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Icon): Emoji & settings icon update#991
Merged
Conversation
jaanus03
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
jaanus03
added
🚀 ready for review
🧰 fix
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
+ Coverage 81.1% 81.11% +0.01%
==========================================
Files 671 672 +1
Lines 8627 8633 +6
Branches 1520 1456 -64
==========================================
+ Hits 6997 7003 +6
Misses 1615 1615
Partials 15 15
Continue to review full report at Codecov.
|
jaanus03
force-pushed
the
jaanusp/icon-updates
branch
from
0b9cb34 to
3cd6bf5
Compare
codepretty
approved these changes
Feb 28, 2019
codepretty
reviewed
Feb 28, 2019
Collaborator
There was a problem hiding this comment.
We might want to consider renaming this to 'cog'. We want to start moving to a generic name icons that match what the icon looks like and not use-specific naming that we currently do in Teams.
For example in Font Awesome it is called 'cog' - https://fontawesome.com/icons?d=gallery&q=cog
jaanus03
changed the title
layershifter
changed the title
layershifter
changed the title
layershifter
changed the title
layershifter
approved these changes
Mar 1, 2019
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
Please add a changelog entry
jaanus03
force-pushed
the
jaanusp/icon-updates
branch
from
3cd6bf5 to
ffe16a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the emoji icon filled version & added settings icon.
Current filled emoji icon:
New emoji icon:
New settings icon:
