Allow workflow filenames, not just workflow IDs#39
Merged
styfle merged 2 commits intostyfle:mainfrom Oct 24, 2020
Merged
Conversation
added 2 commits
October 19, 2020 12:08
Github supports passing the workflow filenames instead of workflow ids. Unfortunately, octokit's typescript bindings dont support this, so we need to ignore one line. Pull Request Branch: palasha/support_filename_based_workflow_ids Pull Request Link: #1
…kflow_ids Support filename based workflow_ids
Owner
|
Very cool! This will fix #2. Is there an upstream PR to fix octokit types? |
Contributor
Author
|
I believe this is the issue where its being tracked, but its hard to figure out with all the different octokit repos. |
styfle
added a commit
that referenced
this pull request
Oct 24, 2020
Add a test for #39 and update docs
This was referenced Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.github.com/en/free-pro-team@latest/rest/reference/actions#list-workflow-runs
Github supports passing the workflow filenames instead of workflow ids. Under the
worklow_idparameter, it says,"You can also pass the workflow file name as a string."Unfortunately, octokit's typescript bindings dont support this, so I need to ignore one line to allow the string through. At runtime, this works without issues.