Move json_native configuration to databackend
#2867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
blythed
force-pushed
the
task/2857/json-native-better-solution
branch
from
a7dd549 to
bbd669f
Compare
jieguangzhou
reviewed
Jun 9, 2025
Comment on lines
+30
to
+34
| json_native: bool = False | ||
|
|
||
| batched: bool = False | ||
| id_field: str = 'id' | ||
| vector_impl: t.Type = NativeVector |
Contributor
There was a problem hiding this comment.
How about using a set of datatype implementations like this? That way, we can optimize the logic and make it easier to extend.
datatypes_impl = {"vector": NativeVector, "json": "JsonXXX"}
Collaborator
Author
There was a problem hiding this comment.
On second thoughts, the situation of json_native is slightly different. This is to do with splitting up the logic of encoding between superduper and databackend. JSON and vectors are special, because they are handled in specific ways by the databackend.
blythed
force-pushed
the
task/2857/json-native-better-solution
branch
from
bbd669f to
e59e26d
Compare
blythed
force-pushed
the
task/2857/json-native-better-solution
branch
6 times, most recently
from
fd6fe57 to
8c773b8
Compare
blythed
force-pushed
the
task/2857/json-native-better-solution
branch
from
8c773b8 to
4717460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
make unit_testingandmake integration-testingsuccessfully?Additional Notes or Comments