Skip to content

Fix/mute incorrect#195

Merged
svrooij merged 2 commits intobetafrom
fix/mute-incorrect
May 1, 2024
Merged

Fix/mute incorrect#195
svrooij merged 2 commits intobetafrom
fix/mute-incorrect

Conversation

@svrooij
Copy link
Owner

@svrooij svrooij commented May 1, 2024

Parsing mute correctly

Description

After the recent xml upgrade, the value for Mute was no longer parsed correctly.

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the beta branch (left side). Also you should start your branch off svrooij/node-sonos-ts/beta.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • Check you add tests for added code.

💔 Thank you!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8907396651

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 78.628%

Totals Coverage Status
Change from base Build 8493887109: 0.03%
Covered Lines: 1703
Relevant Lines: 2123

💛 - Coveralls

@svrooij svrooij merged commit c6d6e5d into beta May 1, 2024
@github-actions
Copy link

github-actions bot commented May 1, 2024

🎉 This PR is included in version 2.6.0-beta.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@svrooij svrooij deleted the fix/mute-incorrect branch February 24, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants