perf(ui): make forge info 14x faster (#2123)

Author: tusharmath

crates/forge_main/src/ui.rs

@@ -270,8 +270,8 @@ impl<A: API + 'static, F: Fn() -> A + Send + Sync> UI<A, F> {
     }
 
     async fn run_inner(&mut self) -> Result<()> {
-        if let Some(mcp) = self.cli.subcommands.clone() {
-            return self.handle_subcommands(mcp).await;
+        if let Some(cmd) = self.cli.subcommands.clone() {
+            return self.handle_subcommands(cmd).await;
         }
 
         // Display the banner in dimmed colors since we're in interactive mode
@@ -2291,7 +2291,6 @@ impl<A: API + 'static, F: Fn() -> A + Send + Sync> UI<A, F> {
         let workflow = self.api.read_workflow(self.cli.workflow.as_deref()).await?;
 
         let _ = self.handle_migrate_credentials().await;
-        self.install_vscode_extension();
 
         // Ensure we have a model selected before proceeding with initialization
         let active_agent = self.api.get_active_agent().await;
@@ -2361,6 +2360,8 @@ impl<A: API + 'static, F: Fn() -> A + Send + Sync> UI<A, F> {
     async fn on_message(&mut self, content: Option<String>) -> Result<()> {
         let conversation_id = self.init_conversation().await?;
 
+        self.install_vscode_extension();
+
         // Track if content was provided to decide whether to use piped input as
         // additional context
         let has_content = content.is_some();
@@ -3107,6 +3108,9 @@ impl<A: API + 'static, F: Fn() -> A + Send + Sync> UI<A, F> {
 
     /// Silently install VS Code extension if in VS Code and extension not
     /// installed.
+    /// NOTE: This is a non-cancellable and a slow task. We should only run this
+    /// if the user has provided a prompt because that is guaranteed to run for
+    /// at least a few seconds.
     fn install_vscode_extension(&self) {
         tokio::task::spawn_blocking(|| {
             if crate::vscode::should_install_extension() {

scripts/test_forge_info_performance.sh

@@ -0,0 +1,89 @@
+#!/usr/bin/env bash
+
+# Performance test script for forge info command
+# Runs the command 10 times and collects timing statistics
+
+set -euo pipefail
+
+# Colors and styling
+BOLD='\033[1m'
+DIM='\033[2m'
+RESET='\033[0m'
+GREEN='\033[32m'
+YELLOW='\033[33m'
+CYAN='\033[36m'
+GRAY='\033[90m'
+
+# Configuration
+COMMAND="target/debug/forge info"
+ITERATIONS=10
+TIMES=()
+
+# Header
+echo ""
+echo -e "🚀 ${BOLD}Performance Test${RESET} ${DIM}—${RESET} ${CYAN}forge info${RESET}"
+echo ""
+
+# Build step
+echo -e "${GRAY}📦 Building...${RESET}"
+cargo build 2>&1 | grep -E "Compiling|Finished" | tail -1
+echo ""
+
+# Show sample output
+echo -e "${GRAY}📋 Sample output:${RESET}"
+echo ""
+$COMMAND
+echo ""
+
+# Run performance tests
+echo -e "${GRAY}⏱️  Running ${YELLOW}$ITERATIONS${GRAY} iterations...${RESET}"
+echo ""
+
+for i in $(seq 1 $ITERATIONS); do
+    # Measure execution time
+    START=$(date +%s%N)
+    $COMMAND > /dev/null 2>&1
+    END=$(date +%s%N)
+    
+    # Calculate duration in milliseconds
+    DURATION=$(( (END - START) / 1000000 ))
+    TIMES+=($DURATION)
+    
+    # Color code based on performance
+    if [ $DURATION -lt 50 ]; then
+        COLOR=$GREEN
+    elif [ $DURATION -lt 100 ]; then
+        COLOR=$YELLOW
+    else
+        COLOR=$GRAY
+    fi
+    
+    printf "  ${DIM}%2d${RESET}  ${COLOR}%5d${RESET} ${DIM}ms${RESET}\n" $i $DURATION
+done
+
+echo ""
+
+# Calculate statistics
+TOTAL=0
+MIN=${TIMES[0]}
+MAX=${TIMES[0]}
+
+for time in "${TIMES[@]}"; do
+    TOTAL=$((TOTAL + time))
+    if [ $time -lt $MIN ]; then
+        MIN=$time
+    fi
+    if [ $time -gt $MAX ]; then
+        MAX=$time
+    fi
+done
+
+AVG=$((TOTAL / ITERATIONS))
+
+# Results summary
+echo -e "📊 ${BOLD}Summary${RESET}"
+echo ""
+printf "  ${DIM}avg${RESET}  ${CYAN}%5d${RESET} ${DIM}ms${RESET}\n" $AVG
+printf "  ${DIM}min${RESET}  ${GREEN}%5d${RESET} ${DIM}ms${RESET}\n" $MIN
+printf "  ${DIM}max${RESET}  ${YELLOW}%5d${RESET} ${DIM}ms${RESET}\n" $MAX
+echo ""