feat(update): update forge in bg (#2466)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Tushar Mathur <tusharmath@gmail.com>

Author: 3 people

crates/forge_domain/src/update.rs

@@ -1,5 +1,6 @@
 use std::time::Duration;
 
+use derive_setters::Setters;
 use merge::Merge;
 use schemars::JsonSchema;
 use serde::{Deserialize, Serialize};
@@ -23,7 +24,7 @@ impl From<UpdateFrequency> for Duration {
     }
 }
 
-#[derive(Debug, Clone, Serialize, Deserialize, Merge, Default, JsonSchema)]
+#[derive(Debug, Clone, Serialize, Deserialize, Merge, Default, JsonSchema, Setters)]
 #[merge(strategy = merge::option::overwrite_none)]
 pub struct Update {
     pub frequency: Option<UpdateFrequency>,

crates/forge_main/src/cli.rs

@@ -149,6 +149,9 @@ pub enum TopLevelCommand {
     /// VS Code integration commands.
     #[command(subcommand)]
     Vscode(VscodeCommand),
+
+    /// Update forge to the latest version.
+    Update(UpdateArgs),
 }
 
 /// Command group for custom command management.
@@ -719,6 +722,14 @@ pub enum VscodeCommand {
     InstallExtension,
 }
 
+/// Update command arguments.
+#[derive(Parser, Debug, Clone)]
+pub struct UpdateArgs {
+    /// Skip the confirmation prompt when applying updates.
+    #[arg(long, default_value_t = false)]
+    pub no_confirm: bool,
+}
+
 #[cfg(test)]
 mod tests {
     use clap::Parser;
@@ -1704,4 +1715,24 @@ mod tests {
         let expected = false;
         assert_eq!(actual, expected);
     }
+
+    #[test]
+    fn test_update_with_no_confirm() {
+        let fixture = Cli::parse_from(["forge", "update", "--no-confirm"]);
+        let actual = match fixture.subcommands {
+            Some(TopLevelCommand::Update(args)) => args.no_confirm,
+            _ => panic!("Expected Update command"),
+        };
+        assert!(actual);
+    }
+
+    #[test]
+    fn test_update_without_no_confirm() {
+        let fixture = Cli::parse_from(["forge", "update"]);
+        let actual = match fixture.subcommands {
+            Some(TopLevelCommand::Update(args)) => args.no_confirm,
+            _ => panic!("Expected Update command"),
+        };
+        assert!(!actual);
+    }
 }

crates/forge_main/src/ui.rs

@@ -670,6 +670,11 @@ impl<A: API + ConsoleWriter + 'static, F: Fn() -> A + Send + Sync> UI<A, F> {
                 }
                 return Ok(());
             }
+            TopLevelCommand::Update(args) => {
+                let update = forge_domain::Update::default().auto_update(Some(args.no_confirm));
+                on_update(self.api.clone(), Some(&update)).await;
+                return Ok(());
+            }
         }
         Ok(())
     }

crates/forge_main/src/update.rs

@@ -5,8 +5,10 @@ use forge_api::{API, Update};
 use forge_tracker::VERSION;
 use update_informer::{Check, Version, registry};
 
-/// Runs the official installation script to update Forge, failing silently
-async fn execute_update_command(api: Arc<impl API>) {
+/// Runs the official installation script to update Forge, failing silently.
+/// When `auto_update` is true, exits immediately after a successful update
+/// without prompting the user.
+async fn execute_update_command(api: Arc<impl API>, auto_update: bool) {
     // Spawn a new task that won't block the main application
     let output = api
         .execute_shell_command_raw("curl -fsSL https://forgecode.dev/cli | sh")
@@ -20,12 +22,17 @@ async fn execute_update_command(api: Arc<impl API>) {
         }
         Ok(output) => {
             if output.success() {
-                let answer = forge_select::ForgeSelect::confirm(
-                    "You need to close forge to complete update. Do you want to close it now?",
-                )
-                .with_default(true)
-                .prompt();
-                if answer.unwrap_or_default().unwrap_or_default() {
+                let should_exit = if auto_update {
+                    true
+                } else {
+                    let answer = forge_select::ForgeSelect::confirm(
+                        "You need to close forge to complete update. Do you want to close it now?",
+                    )
+                    .with_default(true)
+                    .prompt();
+                    answer.unwrap_or_default().unwrap_or_default()
+                };
+                if should_exit {
                     std::process::exit(0);
                 }
             } else {
@@ -75,7 +82,7 @@ pub async fn on_update(api: Arc<impl API>, update: Option<&Update>) {
     if let Some(version) = informer.check_version().ok().flatten()
         && (auto_update || confirm_update(version).await)
     {
-        execute_update_command(api).await;
+        execute_update_command(api, auto_update).await;
     }
 }
 

shell-plugin/lib/actions/core.zsh

@@ -23,6 +23,8 @@ function _forge_action_new() {
 
         # Start background sync job if enabled and not already running
         _forge_start_background_sync
+        # Start background update check
+        _forge_start_background_update
     else
         # Only show banner if no input text (starting fresh conversation)
         _forge_exec banner

shell-plugin/lib/dispatcher.zsh

@@ -77,6 +77,8 @@ function _forge_action_default() {
 
     # Start background sync job if enabled and not already running
     _forge_start_background_sync
+    # Start background update check
+    _forge_start_background_update
 }
 
 function forge-accept-line() {

shell-plugin/lib/helpers.zsh

@@ -138,3 +138,16 @@ function _forge_start_background_sync() {
     } &!
 }
 
+# Start background update check if not already running
+# Mirrors the background sync pattern to silently check for and apply updates
+function _forge_start_background_update() {
+    {
+        # Run update check in background
+        # Close all output streams immediately to prevent any flashing
+        # Redirect stdin to /dev/null to prevent hanging
+        exec >/dev/null 2>&1 </dev/null
+        setopt NO_NOTIFY NO_MONITOR
+        $_FORGE_BIN update --no-confirm
+    } &!
+}
+