Skip to content
Qodana

refactor(api)!: simplify event building methods by removing sender pa… #73

Sign in to view logs

refactor(api)!: simplify event building methods by removing sender pa…

refactor(api)!: simplify event building methods by removing sender pa… #73

Triggered via push October 14, 2025 00:27
@tcheerictcheeric
pushed 58bceed
develop
Status Success
Total duration 2m 48s
Artifacts –

qodana_code_quality.yml

on: push
qodana
2m 44s
qodana
Fit to window
Zoom out
Zoom in

Annotations

59 warnings and 4 notices
AutoCloseable used without 'try'-with-resources: nostr-java-api/src/main/java/nostr/api/WebSocketClientHandler.java#L187
'SpringWebSocketClient' used without 'try'-with-resources statement
Catch block may ignore exception: nostr-java-api/src/main/java/nostr/api/nip57/NIP57ZapReceiptBuilder.java#L80
Unexpected VM exception like 'java.lang.NullPointerException' might be ignored in a `catch` block
Dangling Javadoc comment: nostr-java-event/src/main/java/nostr/event/tag/LabelTag.java#L16
Dangling Javadoc comment
Dangling Javadoc comment: nostr-java-event/src/main/java/nostr/event/tag/LabelNamespaceTag.java#L16
Dangling Javadoc comment
Default annotation parameter value: nostr-java-client/src/main/java/nostr/client/springwebsocket/NostrRetryable.java#L17
Redundant default parameter value assignment
Deprecated API usage: nostr-java-client/src/main/java/nostr/client/springwebsocket/NostrRetryable.java#L16
'include' is deprecated
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrNetworkException.java#L117
Symbol `nostr.config.RelayConfig` is inaccessible from here
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrCryptoException.java#L80
Symbol `nostr.event.impl.GenericEvent` is inaccessible from here
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrCryptoException.java#L81
Cannot resolve symbol `verify()`
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrEncodingException.java#L111
Symbol `nostr.event.json.codec.BaseEventEncoder` is inaccessible from here
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrProtocolException.java#L69
Symbol `validate()` is inaccessible from here
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrEncodingException.java#L112
Symbol `nostr.crypto.bech32.Bech32` is inaccessible from here
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrCryptoException.java#L80
Cannot resolve symbol `sign(nostr.event.impl.GenericEvent)`
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrCryptoException.java#L79
Symbol `nostr.crypto.schnorr.Schnorr` is inaccessible from here
Declaration has problems in Javadoc references: nostr-java-crypto/src/main/java/nostr/crypto/bech32/Bech32Prefix.java#L124
Symbol `nostr.base.PublicKey` is inaccessible from here
Declaration has problems in Javadoc references: nostr-java-crypto/src/main/java/nostr/crypto/bech32/Bech32Prefix.java#L125
Cannot resolve symbol `toBech32()`
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrNetworkException.java#L116
Cannot resolve symbol `nostr.api.client.NostrSpringWebSocketClient`
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrProtocolException.java#L69
Symbol `nostr.event.impl.GenericEvent` is inaccessible from here
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrNetworkException.java#L115
Cannot resolve symbol `nostr.api.client.StandardWebSocketClient`
Declaration has problems in Javadoc references: nostr-java-crypto/src/main/java/nostr/crypto/bech32/Bech32Prefix.java#L125
Symbol `nostr.base.PrivateKey` is inaccessible from here
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrCryptoException.java#L81
Symbol `nostr.event.impl.GenericEvent` is inaccessible from here
Declaration has problems in Javadoc references: nostr-java-util/src/main/java/nostr/util/exception/NostrCryptoException.java#L80
Symbol `nostr.id.Identity` is inaccessible from here
Declaration has problems in Javadoc references: nostr-java-crypto/src/main/java/nostr/crypto/bech32/Bech32Prefix.java#L124
Cannot resolve symbol `toBech32()`
Lombok @Getter may be used: nostr-java-api/src/main/java/nostr/api/client/NostrRelayRegistry.java#L33
Field 'clientMap' may have Lombok @Getter
Lombok @Getter may be used: nostr-java-crypto/src/main/java/nostr/crypto/Point.java#L17
Class 'Point' may use Lombok @Getter
Lombok @Setter may be used: nostr-java-api/src/main/java/nostr/api/service/impl/DefaultNoteService.java#L50
Field 'failureListener' may have Lombok @Setter
@NotNull/@Nullable problems: nostr-java-base/src/main/java/nostr/base/BaseKey.java#L26
Primitive type members cannot be annotated
Redundant type cast: nostr-java-api/src/main/java/nostr/api/EventNostr.java#L61
Casting `decoder.decode(...)` to `U` is redundant
Redundant type arguments: nostr-java-examples/src/main/java/nostr/examples/TextNoteEventExample.java#L23
Explicit type arguments can be inferred
'size() == 0' can be replaced with 'isEmpty()': nostr-java-event/src/main/java/nostr/event/json/deserializer/TagDeserializer.java#L58
`node.size() == 0` can be replaced with 'node.isEmpty()'
'size() == 0' can be replaced with 'isEmpty()': nostr-java-event/src/main/java/nostr/event/tag/ReferenceTag.java#L65
`genericTag.getAttributes().size() < 1` can be replaced with 'genericTag.getAttributes().isEmpty()'
Suspicious variable/parameter name combination: nostr-java-crypto/src/main/java/nostr/crypto/Point.java#L37
'y' should probably not be passed as parameter 'elementRight'
Unchecked warning: nostr-java-api/src/main/java/nostr/api/NIP60.java#L260
Unchecked call to 'GenericEventFactory(Identity, Integer, List, String)' as a member of raw type 'nostr.api.factory.impl.GenericEventFactory'
Unchecked warning: nostr-java-event/src/main/java/nostr/event/entities/CalendarContent.java#L122
Unchecked cast: 'nostr.event.tag.@lombok.NonNull ReferenceTag' to 'T'
Unchecked warning: nostr-java-event/src/main/java/nostr/event/entities/CalendarContent.java#L154
Unchecked cast: 'nostr.event.tag.@lombok.NonNull AddressTag' to 'T'
Unchecked warning: nostr-java-event/src/main/java/nostr/event/entities/CalendarContent.java#L98
Unchecked cast: 'nostr.event.tag.@lombok.NonNull PubKeyTag' to 'T'
Unchecked warning: nostr-java-event/src/main/java/nostr/event/entities/CalendarContent.java#L142
Unchecked cast: 'nostr.event.tag.@lombok.NonNull LabelNamespaceTag' to 'T'
Unchecked warning: nostr-java-api/src/main/java/nostr/api/NIP60.java#L235
Unchecked call to 'GenericEventFactory(Identity, Integer, List, String)' as a member of raw type 'nostr.api.factory.impl.GenericEventFactory'
Unchecked warning: nostr-java-event/src/main/java/nostr/event/json/codec/GenericEventDecoder.java#L18
Unchecked cast: 'java.lang.Class' to 'java.lang.Class'
Unchecked warning: nostr-java-api/src/main/java/nostr/api/NIP60.java#L272
Unchecked call to 'GenericEventFactory(Identity, Integer, List, String)' as a member of raw type 'nostr.api.factory.impl.GenericEventFactory'
Unchecked warning: nostr-java-api/src/main/java/nostr/api/NIP60.java#L247
Unchecked call to 'GenericEventFactory(Identity, Integer, List, String)' as a member of raw type 'nostr.api.factory.impl.GenericEventFactory'
Unchecked warning: nostr-java-event/src/main/java/nostr/event/entities/CalendarContent.java#L162
Unchecked cast: 'nostr.event.tag.@lombok.NonNull GeohashTag' to 'T'
Unchecked warning: nostr-java-event/src/main/java/nostr/event/json/codec/BaseMessageDecoder.java#L45
Unchecked cast: 'java.util.Map,capture\>' to 'java.util.Map'
Unchecked warning: nostr-java-api/src/main/java/nostr/api/NIP09.java#L45
Unchecked call to 'GenericEventFactory(Identity, Integer, List, String)' as a member of raw type 'nostr.api.factory.impl.GenericEventFactory'
Unchecked warning: nostr-java-event/src/main/java/nostr/event/entities/CalendarContent.java#L130
Unchecked cast: 'nostr.event.tag.@lombok.NonNull LabelTag' to 'T'
Unchecked warning: nostr-java-api/src/main/java/nostr/api/NIP02.java#L32
Unchecked call to 'GenericEventFactory(Identity, Integer, List, String)' as a member of raw type 'nostr.api.factory.impl.GenericEventFactory'
Unchecked warning: nostr-java-event/src/main/java/nostr/event/entities/CalendarContent.java#L110
Unchecked cast: 'nostr.event.tag.@lombok.NonNull HashtagTag' to 'T'
Unchecked warning: nostr-java-event/src/main/java/nostr/event/message/CloseMessage.java#L43
Unchecked cast: 'nostr.event.message.CloseMessage' to 'T'
Redundant local variable: nostr-java-event/src/main/java/nostr/event/impl/NutZapEvent.java#L103
Local variable `cashuProof` is redundant
Redundant local variable: nostr-java-event/src/main/java/nostr/event/tag/IdentifierTag.java#L35
Local variable `identifierTag` is redundant
Redundant local variable: nostr-java-event/src/main/java/nostr/event/tag/PubKeyTag.java#L86
Local variable `pubKeyTag` is redundant
Redundant local variable: nostr-java-event/src/main/java/nostr/event/impl/NutZapEvent.java#L97
Local variable `mint` is redundant
Redundant local variable: nostr-java-event/src/main/java/nostr/event/tag/SubjectTag.java#L50
Local variable `subjectTag` is redundant
Redundant local variable: nostr-java-event/src/main/java/nostr/event/entities/CalendarContent.java#L171
Local variable `list` is redundant
Redundant local variable: nostr-java-event/src/main/java/nostr/event/tag/EmojiTag.java#L46
Local variable `emojiTag` is redundant
Redundant local variable: nostr-java-event/src/main/java/nostr/event/tag/LabelNamespaceTag.java#L35
Local variable `labelNamespaceTag` is redundant
Redundant local variable: nostr-java-event/src/main/java/nostr/event/entities/CalendarContent.java#L180
Local variable `baseTags` is redundant
qodana
You are using a non-compatible Qodana linter jetbrains/qodana-jvm-community:2025.1 with the current CLI (2025.2.1)
qodana
You are using a non-compatible Qodana linter jetbrains/qodana-jvm-community:2025.1 with the current CLI (2025.2.1)
Method can be extracted: nostr-java-api/src/main/java/nostr/api/nip57/Bolt11Util.java#L40
It's possible to extract method returning 'msat' from a long surrounding method
@NotNull/@Nullable problems: nostr-java-base/src/main/java/nostr/base/BaseKey.java#L24
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@lombok.NonNull'
@NotNull/@Nullable problems: nostr-java-api/src/main/java/nostr/api/nip57/ZapRequestParameters.java#L24
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@lombok.NonNull'
@NotNull/@Nullable problems: nostr-java-api/src/main/java/nostr/api/nip57/ZapRequestParameters.java#L25
The generated code will use '@org.jetbrains.annotations.NotNull' instead of '@lombok.NonNull'