feat: added example for cross regional internal lb with gce mig as backend#500
Merged
q2w merged 6 commits intoterraform-google-modules:mainfrom Apr 21, 2025
Merged
Conversation
pawan1210
requested review from
a team,
ayushmjain,
imrannayer and
q2w
as code owners
pawan1210
force-pushed
the
feat/internal-lb-gce-mig
branch
3 times, most recently
from
c49ae6b to
07d21d9
Compare
pawan1210
force-pushed
the
feat/internal-lb-gce-mig
branch
from
07d21d9 to
887dbe0
Compare
q2w
reviewed
Apr 14, 2025
pawan1210
force-pushed
the
feat/internal-lb-gce-mig
branch
from
f7a789f to
d010619
Compare
q2w
reviewed
Apr 17, 2025
modules/backend/variables.tf
Outdated
| variable "firewall_source_ranges" { | ||
| description = "Source ranges for the global Application Load Balancer's proxies. This list should contain the `ip_cidr_range` of each GLOBAL_MANAGED_PROXY subnet." | ||
| type = list(string) | ||
| default = ["10.129.0.0/23"] |
Collaborator
There was a problem hiding this comment.
Let's have a default value as 10.127.0.0/23. This is an IP address outside of reserve range of IP addresses for default network. We will have this value as default for Proxy only subnet #501 (review)
pawan1210
force-pushed
the
feat/internal-lb-gce-mig
branch
from
59eeaca to
e2591f4
Compare
q2w
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.