Skip to content

feat: sync primitives, network initialization#3

Merged
hacdias merged 10 commits intomasterfrom
first-iteration
Oct 3, 2020
Merged

feat: sync primitives, network initialization#3
hacdias merged 10 commits intomasterfrom
first-iteration

Conversation

@hacdias
Copy link
Member

@hacdias hacdias commented Oct 2, 2020

This "small" first iteration adds:

  • Sync Primitives: barriers, publish, subscribe, sugar methods, etc.
  • Network initialization.

@hacdias hacdias changed the title First Iteration feat: sync primitives, network initialization Oct 3, 2020
@hacdias hacdias requested a review from nonsense October 3, 2020 16:16
@hacdias
Copy link
Member Author

hacdias commented Oct 3, 2020

@jacobheun @nonsense so I finish a first iteration. Most likely something will break. Next week I will work on a ping pong example (with the docker:generic builder) and make sure everything I wrote is working. After that, I will implement the docker:node builder, add some jsdoc for some good autocompletion, as well as update the README.

One question: we will have to publish this eventually on npm. Should the package be @testground/sdk or testground-sdk?

I'm merging this right now. However, please check the PR and I will update/fix/reply to your comments later.

@hacdias hacdias marked this pull request as ready for review October 3, 2020 16:18
@hacdias hacdias merged commit 5ee5d6b into master Oct 3, 2020
@hacdias hacdias deleted the first-iteration branch October 3, 2020 16:20
@jacobheun
Copy link

One question: we will have to publish this eventually on npm. Should the package be @testground/sdk or testground-sdk?

@hacdias I'd recommend just creating the testground org in npm and going with @testground/sdk, as the org setup makes it easier IMO to manage user access for publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants