Skip to content

Comments

feat: add syncClient.signalEvent#5

Merged
hacdias merged 2 commits intomasterfrom
events
Oct 16, 2020
Merged

feat: add syncClient.signalEvent#5
hacdias merged 2 commits intomasterfrom
events

Conversation

@hacdias
Copy link
Member

@hacdias hacdias commented Oct 16, 2020

This small PR is intended to restore the functionality of sdk-js which is broken due to the last updates to Testground and sdk-go (testground/sdk-go#31).

What this PR does:

  • Adds signalEvent to the sync client
  • Uses the events on network and runtime

What this PR does not do:

  • Add a watch client

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias requested a review from nonsense October 16, 2020 16:14
@hacdias hacdias marked this pull request as ready for review October 16, 2020 16:14
@hacdias
Copy link
Member Author

hacdias commented Oct 16, 2020

I'm merging this @nonsense, but please take a look afterwards!

@hacdias hacdias merged commit d4fc609 into master Oct 16, 2020
@hacdias hacdias deleted the events branch October 16, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant