error on torrent names with colons

[ouroborus]

Shows error "invalid argument" and doesn't add torrent if magnet link is for a torrent whose name includes colons.

Windows 10
transgui 5.12

[antekgla]

Please post a example of torrent or magnet what give you this error.
Thanks!

PD: your Transmission daemon (not TransGUI!) is running in Linux? because colons are illegal in folders/filenames in Windows.
Quoted from Microsoft Site

Use any character in the current code page for a name, including Unicode characters and characters in the extended character set (128–255), except for the following:

The following reserved characters:
    < (less than)
    > (greater than)
    : (colon)
    " (double quote)
    / (forward slash)
    \ (backslash)
    | (vertical bar or pipe)
    ? (question mark)
    * (asterisk)

[ouroborus]

@antekgla The daemon is indeed running on Linux. TransGUI is running on Windows.

However, AFAIK, the name in the magnet link doesn't matter as far as OS compatibility is concerned as it isn't used in naming the folder/files. The torrent file itself has the actual file/folder names and those are used.

magnet:?xt=urn:btih:ba1e75d3f1a44b41691bcdb8c897c081630ae653&dn=linuxmint%3A18.3%20mate%2064bit.iso

[antekgla]

@leonsoft-kras I think what this is related to the new function ExcludeInvalidChar
This function remove the illegal characters in Windows, but in Linux that characters are valid. So maybe we would have to review its implementation.

However the error is fired for another reason related.
#### Edited because the conclusion was wrong but not the origin ####

[leonsoft-kras]

I will look at the holidays ))

[leonsoft-kras]

I did it differently recently, but I'll try to see your version.

In general there was no time. I wanted to ask a question, but for now I'll look at your option.

[antekgla]

Wait, A further look debugging I can say what I was wrong...
The torrent is added with the illegal character (I was confused because in the Add form the illegal chars are removed, running a second copy of transgui while the main was paused I can see what the torrent is added with the illegal chars.
Sorry about the confusion. 😢

I think what I know the problem, forget my previous long post, it is totally wrong. I edited that post because cause confussion.

[antekgla]

@ouroborus please write here the transmission daemon version (it is in the statusbar first panel)
Thanks!

[leonsoft-kras]

I have not added the torrent either. it is necessary to look.

[antekgla]

The problem I think (I need what @ouroborus confirm) his (and mine) Transmission Daemon is prior to 2.80 (mine is 2.61) so dont accept method:

torrent-rename-path

introduced in Transmission 2.80 so when TransGUI try to rename the torrent without illegal chars, fires the error "invalid argument"

I check this:
I have 2 NAS.
One with Transmission 2.61 (dont accept rename) and other with Transmission 2.84 (accept rename).
When I add that magnet in 2.61 fires the error.
When I add in Transmission 2.84 no error at all.

If you use original TransGUI 5.01 in 2.61 no error, because the ExcludeInvalidChar function dont exist and how daemon is in Linux the colon are accepted character.
Maybe prior to use

torrent-rename-path

we need to check RPC-version.

[leonsoft-kras]

I fixed the problem 50/50 (excluded symbol ":").

The torrent was invented by a strange person. It does contain invalid characters, in particular ":". Another strange thing is that after adding a torrent in a few seconds, the name is replaced with ":" and a space for the "-" character.

The original name: linuxmint:18.3 mate 64bit.iso
The final name after the start torrent: linuxmint-18.3-mate-64bit.iso

I checked the function "torrent-rename-path" on another torrent file. It works successfully. The file is renamed without errors. My version of the transmission (on Zyxel Keenetic) 2.84 (14307)

[antekgla]

I checked the function "torrent-rename-path" on another torrent file. It works successfully. The file is renamed without errors. My version of the transmission (on Zyxel Keenetic) 2.84 (14307)

Thats is because the version 2.84 supports renaming a torrent/file but in versions prior to 2.80 that method not exist.
TransGUI dont show the Rename menu option in RPC<15. The problem here is what the user is adding a torrent but (because the illegal chars) TransGUI is executing rename anyway.
Try to add this torrent in Transmission < 2.80 and you get the error.

[leonsoft-kras]

Why do check RPC if I have the latest 2.84 and the error is with this torrent happens.