Merged
Conversation
hovaesco
reviewed
Jan 5, 2023
Member
hovaesco
left a comment
hovaesco
left a comment
There was a problem hiding this comment.
Thank you for doing this, maybe we should also have an example with an old approach in README?
mdesmet
force-pushed
the
feat/enhance-roles-parameter
branch
from
3d36ad1 to
2dc08c6
Compare
Contributor
Author
Well, the old approach is not anymore relevant after this PR. Our docs were already compliant, see https://github.com/trinodb/trino-python-client/blob/master/README.md#roles |
hashhar
approved these changes
Jan 5, 2023
hovaesco
approved these changes
Jan 5, 2023
hashhar
reviewed
Jan 6, 2023
| def _format_roles(self, roles): | ||
| formatted_roles = {} | ||
| for catalog, role in roles.items(): | ||
| if role in ("NONE", "ALL") or ROLE_PATTERN.match(role) is not None: |
Member
There was a problem hiding this comment.
If role matches the ROLE_PATTERN can we use warnings.warn to tell user to fix it instead of silently accepting it?
Long term supporting both syntaxes may not actually solve the confusion.
@mdesmet Can you do this as a follow-up PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the jdbc driver custom roles are enclosed in
ROLE{rolename}automatically. This was not yet implemented in the Trino python client, causing confusion.This PR adds this enclosing automatically, while checking if the enclosing is not already provided to ensure backwards compatiblity.
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:
* Enclose custom roles passed in Connection into Trino protocol specific formatting (ROLE{rolename})