Enhance Cursor.description with type information#315
Merged
hashhar merged 1 commit intotrinodb:masterfrom Jan 11, 2023
Merged
Conversation
mdesmet
force-pushed
the
feature/improve-description
branch
from
0e9833e to
cb29b0f
Compare
hovaesco
approved these changes
Jan 8, 2023
mdesmet
force-pushed
the
feature/improve-description
branch
from
cb29b0f to
74cb3d7
Compare
hashhar
reviewed
Jan 10, 2023
hashhar
approved these changes
Jan 10, 2023
This was referenced Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add internal_size, precision, scale to Cursor.description to make it easier to get type information of a result set.
Note that if this information can be extracted from the type, this is also removed from the type_code, making it easier to match upon.
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:
* Add type information to DBAPI's cursor description (internal_size, scale, precision)