Add support for 'None' on response data#443
Merged
hashhar merged 1 commit intotrinodb:masterfrom Jan 31, 2024
Merged
Conversation
Member
|
To write a unit test here please create mock like and then see how it's used in teststrino-python-client/tests/unit/test_client.py Line 682 in ca38d29 |
0dc4427 to
2761e07
Compare
hashhar
reviewed
Jan 31, 2024
2761e07 to
061c8f3
Compare
061c8f3 to
627d002
Compare
hashhar
approved these changes
Jan 31, 2024
Member
hashhar
left a comment
There was a problem hiding this comment.
Thanks. Will merge after CI is done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for 'None' on response data
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: