Skip to content

Add support for 'None' on response data#443

Merged
hashhar merged 1 commit intotrinodb:masterfrom
avibhstarburst:master
Jan 31, 2024
Merged

Add support for 'None' on response data#443
hashhar merged 1 commit intotrinodb:masterfrom
avibhstarburst:master

Conversation

@avibhstarburst
Copy link
Contributor

@avibhstarburst avibhstarburst commented Jan 30, 2024

Description

Add support for 'None' on response data

Non-technical explanation

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

* Fix possible failures when retrieving query results if the server returns empty data. ({issue}`443`)

@cla-bot cla-bot bot added the cla-signed label Jan 30, 2024
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hovaesco can you guide with how to add a unit test for this (using mocking since not easy to have isolated test case).

@hovaesco
Copy link
Member

To write a unit test here please create mock like

def sample_get_response_data():
and then see how it's used in tests
def test_trino_fetch_request(mock_requests, sample_get_response_data):

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comment.

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will merge after CI is done.

@hashhar hashhar merged commit 191cd79 into trinodb:master Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants