Make this package PEP-561 compatible by adding a py.typed marker#514
Make this package PEP-561 compatible by adding a py.typed marker#514hashhar merged 1 commit intotrinodb:masterfrom
Conversation
|
how can I verify this works as expected? Is it as simple as importing trino module and seeing if |
|
Hi @hashhar - just checking if this is something y'all would be able to merge? To answer your question - yes. As I understand, mypy will assume the package is untyped unless it presents a The presence of the marker file is an intent that "yes, this package is reasonably well typed" to avoid incidentally typing against low quality packages that is untyped and lead to |
|
I checked and it wasn't obvious to me that mypy doesn't check types from libraries unless they have py.typed marker. IDEs for example use type information always (even when using mypy as the backend) so I didn't notice. Thanks for your change. Merging this. |
|
Thanks @hashhar ! |
|
I'll update here once a new version with this is released (probably in a couple of weeks). |
Description
Fixes #482 so that dependent packages can type check themselves against
trino.Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: