From 647ca50a03be9033adafd157f898622cb58d9f83 Mon Sep 17 00:00:00 2001 From: Daniel_Doehring Date: Sun, 1 Mar 2026 09:33:22 +0100 Subject: [PATCH 1/6] Remove unused tols --- .../elixir_advection_diffusion_implicit_sparse_jacobian.jl | 1 - ...lixir_advection_diffusion_implicit_sparse_jacobian_restart.jl | 1 - 2 files changed, 2 deletions(-) diff --git a/examples/tree_1d_dgsem/elixir_advection_diffusion_implicit_sparse_jacobian.jl b/examples/tree_1d_dgsem/elixir_advection_diffusion_implicit_sparse_jacobian.jl index dfa4963d17c..66c0314c01b 100644 --- a/examples/tree_1d_dgsem/elixir_advection_diffusion_implicit_sparse_jacobian.jl +++ b/examples/tree_1d_dgsem/elixir_advection_diffusion_implicit_sparse_jacobian.jl @@ -126,5 +126,4 @@ callbacks = CallbackSet(summary_callback, analysis_callback, alive_callback, sav sol = solve(ode, SBDF2(; autodiff = AutoFiniteDiff()); ode_default_options()..., dt = 0.01, - abstol = 1e-9, reltol = 1e-9, callback = callbacks) diff --git a/examples/tree_1d_dgsem/elixir_advection_diffusion_implicit_sparse_jacobian_restart.jl b/examples/tree_1d_dgsem/elixir_advection_diffusion_implicit_sparse_jacobian_restart.jl index 4e76349f437..1bbb69f64e4 100644 --- a/examples/tree_1d_dgsem/elixir_advection_diffusion_implicit_sparse_jacobian_restart.jl +++ b/examples/tree_1d_dgsem/elixir_advection_diffusion_implicit_sparse_jacobian_restart.jl @@ -25,5 +25,4 @@ ode = semidiscretize(semi, tspan, sol = solve(ode, SBDF2(; autodiff = AutoFiniteDiff()); ode_default_options()..., dt = dt_restart, - abstol = 1e-9, reltol = 1e-9, callback = callbacks); From 431ae70a47c876c830d82c94a5572c5cc11713f1 Mon Sep 17 00:00:00 2001 From: Daniel_Doehring Date: Mon, 2 Mar 2026 10:08:53 +0100 Subject: [PATCH 2/6] Update test vals --- .../elixir_euler_supersonic_cylinder_scO2.jl | 4 ++-- test/test_p4est_2d.jl | 16 ++++++++-------- test/test_tree_2d_advection.jl | 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/examples/p4est_2d_dgsem/elixir_euler_supersonic_cylinder_scO2.jl b/examples/p4est_2d_dgsem/elixir_euler_supersonic_cylinder_scO2.jl index 21a90529a0d..8cc417f75b9 100644 --- a/examples/p4est_2d_dgsem/elixir_euler_supersonic_cylinder_scO2.jl +++ b/examples/p4est_2d_dgsem/elixir_euler_supersonic_cylinder_scO2.jl @@ -113,7 +113,7 @@ amr_controller = ControllerThreeLevel(semi, amr_indicator, max_level = 5, max_threshold = 0.1) amr_callback = AMRCallback(semi, amr_controller, - interval = 2, + interval = 3, adapt_initial_condition = true, adapt_initial_condition_only_refine = true) @@ -130,7 +130,7 @@ stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-7, 1.0e- ############################################################################### # run the simulation -# We supply a small initial timestep to be able to use a larger AMR interval (2 instead of 1) throughout the simulation. +# We supply a small initial timestep to be able to use a larger AMR interval (3 instead of 1) throughout the simulation. # This pays off almost immediately as only the first couple timesteps use this timestep before it is ramped up. dt0 = 1e-8 sol = solve(ode, SSPRK43(stage_limiter! = stage_limiter!, thread = Trixi.True()); diff --git a/test/test_p4est_2d.jl b/test/test_p4est_2d.jl index ec2726adf4b..f15248d7b14 100644 --- a/test/test_p4est_2d.jl +++ b/test/test_p4est_2d.jl @@ -571,16 +571,16 @@ end @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_euler_supersonic_cylinder_scO2.jl"), l2=[ - 0.029314031292054992, - 0.053506886526450186, - 0.03543104168310674, - 0.21538892425489486 + 0.027126649365135935, + 0.05168606881624035, + 0.03257517993369279, + 0.20332788269148155 ], linf=[ - 4.159114155336756, - 4.200427029096135, - 7.397166897133932, - 33.18602863132469 + 3.3564046346597656, + 4.20035322219864, + 6.294233063886822, + 30.26744438954036 ], tspan=(0.0, 0.001)) # Ensure that we do not have excessive memory allocations diff --git a/test/test_tree_2d_advection.jl b/test/test_tree_2d_advection.jl index b4d11b0683d..672555c4c11 100644 --- a/test/test_tree_2d_advection.jl +++ b/test/test_tree_2d_advection.jl @@ -42,7 +42,7 @@ end @trixi_testset "elixir_advection_implicit_sparse_jacobian_restart.jl" begin @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_implicit_sparse_jacobian_restart.jl"), - l2=[0.007964280656552015], linf=[0.011267546271397588]) + l2=[0.00972948620504335], linf=[0.013761951552254348]) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) @test_allocations(Trixi.rhs!, semi_float_type, sol, 1000) @@ -52,7 +52,7 @@ end @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_implicit_sparse_jacobian_restart.jl"), colorvec=nothing, - l2=[0.007964280656552015], linf=[0.011267546271397588]) + l2=[0.00972948620504335], linf=[0.013761951552254348]) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities) @test_allocations(Trixi.rhs!, semi_float_type, sol, 1000) From 513f1731d79a266540e9470117137d7edf5e50e2 Mon Sep 17 00:00:00 2001 From: Daniel_Doehring Date: Mon, 2 Mar 2026 10:56:44 +0100 Subject: [PATCH 3/6] remote vals --- test/test_p4est_2d.jl | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/test/test_p4est_2d.jl b/test/test_p4est_2d.jl index f15248d7b14..cc4d0838b6b 100644 --- a/test/test_p4est_2d.jl +++ b/test/test_p4est_2d.jl @@ -571,16 +571,16 @@ end @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_euler_supersonic_cylinder_scO2.jl"), l2=[ - 0.027126649365135935, - 0.05168606881624035, - 0.03257517993369279, - 0.20332788269148155 + 0.02712606977240808, + 0.05168556045978489, + 0.03257451406056049, + 0.20332455354712423 ], linf=[ - 3.3564046346597656, - 4.20035322219864, - 6.294233063886822, - 30.26744438954036 + 3.356240979194618, + 4.200353602496696, + 6.294181529292024, + 30.266860114392863 ], tspan=(0.0, 0.001)) # Ensure that we do not have excessive memory allocations From c1667d6fe3402f4051ef79ad2a8b6397401e10db Mon Sep 17 00:00:00 2001 From: Daniel_Doehring Date: Mon, 2 Mar 2026 11:19:37 +0100 Subject: [PATCH 4/6] one more --- test/test_mpi_tree.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_mpi_tree.jl b/test/test_mpi_tree.jl index 7152438e7f2..62c74e2fd3c 100644 --- a/test/test_mpi_tree.jl +++ b/test/test_mpi_tree.jl @@ -74,7 +74,7 @@ CI_ON_WINDOWS = (get(ENV, "GITHUB_ACTIONS", false) == "true") && Sys.iswindows() @trixi_testset "elixir_advection_restart_amr.jl" begin @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_advection_restart_amr.jl"), - l2=[8.018498574373939e-5], + l2=[8.018497923389368e-5], linf=[0.0007307237754662355]) end From be5b22daecd359de024b2af81793f308518079d0 Mon Sep 17 00:00:00 2001 From: Daniel_Doehring Date: Mon, 2 Mar 2026 14:13:12 +0100 Subject: [PATCH 5/6] up --- test/test_p4est_2d.jl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/test_p4est_2d.jl b/test/test_p4est_2d.jl index cc4d0838b6b..caf171d9e84 100644 --- a/test/test_p4est_2d.jl +++ b/test/test_p4est_2d.jl @@ -571,16 +571,16 @@ end @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_euler_supersonic_cylinder_scO2.jl"), l2=[ - 0.02712606977240808, - 0.05168556045978489, - 0.03257451406056049, - 0.20332455354712423 + 0.02712606711642512, + 0.051685558070787514, + 0.03257451103198229, + 0.20332453836708636 ], linf=[ - 3.356240979194618, + 3.3562402406176095, 4.200353602496696, - 6.294181529292024, - 30.266860114392863 + 6.294181327101032, + 30.266857583752305 ], tspan=(0.0, 0.001)) # Ensure that we do not have excessive memory allocations From bcedb1722a047ba4fc41572639004dbbf14c3760 Mon Sep 17 00:00:00 2001 From: Daniel_Doehring Date: Mon, 2 Mar 2026 15:20:34 +0100 Subject: [PATCH 6/6] fixed tests --- .../elixir_euler_supersonic_cylinder_scO2.jl | 3 ++- test/test_p4est_2d.jl | 17 +++++++++-------- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/examples/p4est_2d_dgsem/elixir_euler_supersonic_cylinder_scO2.jl b/examples/p4est_2d_dgsem/elixir_euler_supersonic_cylinder_scO2.jl index 8cc417f75b9..fb5fad04534 100644 --- a/examples/p4est_2d_dgsem/elixir_euler_supersonic_cylinder_scO2.jl +++ b/examples/p4est_2d_dgsem/elixir_euler_supersonic_cylinder_scO2.jl @@ -134,4 +134,5 @@ stage_limiter! = PositivityPreservingLimiterZhangShu(thresholds = (5.0e-7, 1.0e- # This pays off almost immediately as only the first couple timesteps use this timestep before it is ramped up. dt0 = 1e-8 sol = solve(ode, SSPRK43(stage_limiter! = stage_limiter!, thread = Trixi.True()); - dt = dt0, ode_default_options()..., callback = callbacks); + adaptive = false, dt = dt0, + ode_default_options()..., callback = callbacks); diff --git a/test/test_p4est_2d.jl b/test/test_p4est_2d.jl index caf171d9e84..c516e3bc4b7 100644 --- a/test/test_p4est_2d.jl +++ b/test/test_p4est_2d.jl @@ -571,17 +571,18 @@ end @test_trixi_include(joinpath(EXAMPLES_DIR, "elixir_euler_supersonic_cylinder_scO2.jl"), l2=[ - 0.02712606711642512, - 0.051685558070787514, - 0.03257451103198229, - 0.20332453836708636 + 0.02952388632922144, + 0.05371261793410487, + 0.035384060637794805, + 0.21588602773829588 ], linf=[ - 3.3562402406176095, - 4.200353602496696, - 6.294181327101032, - 30.266857583752305 + 4.163159992186843, + 4.2267168297270725, + 7.332852278485849, + 34.243826868270645 ], + adaptive=false, dt=1e-5, tspan=(0.0, 0.001)) # Ensure that we do not have excessive memory allocations # (e.g., from type instabilities)