-
Notifications
You must be signed in to change notification settings - Fork 3
New RFC: CODEX-COMMUNITY-HISTORY #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@jimstir this looks to be still a draft since there are missing links, linting issues, typos |
fbarbu15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, approved with some minor comments
| status: raw | ||
| tags: codex | ||
| editor: | ||
| contributors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add someone as contributor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added me as a contributor, when reviewed by Codex team they should ad contributors and an RFC editor.
codex/raw/community-history.md
Outdated
| 2. Download only the latest archive: Request and | ||
| download all pieces starting at the offset of the latest `WakuMessageArchiveIndexMetadata` | ||
| (this is the case for any member node that already has downloaded all previous history and | ||
| is now interested in only the latst archive). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latst typo
codex/raw/community-history.md
Outdated
| For this lookup to work, | ||
| member nodes MUST store the KECCAK-256 hashes, | ||
| of the `WakuMessageArchiveIndexMetadata` provided by the index file, | ||
| for all of the message history archives that have been downlaoded in their local database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
downlaoded typo
|
thanks @jimstir , please request review from Codex devs |
RFC for Codex community history...