fix: alert animation

[mynetfan]

Description

修复AlertDialog组件进入和退出动画无效的问题。

fixed: #5921

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features

  • Introduced an option to apply a customizable blur effect to alert overlays and prompt modals.
  • Enabled a configuration for positioning confirmation modals through a new centering option.

• Refactor

  • Simplified alert closure behavior for improved responsiveness.
  • Refined transition animations and layout structure in dialogs to enhance visual clarity and maintainability.

[coderabbitai]

Walkthrough

This pull request introduces several modifications to alert and modal components. An optional property overlayBlur is added to the alert configuration to control overlay blur effects. The alert component’s closing logic is refactored by removing a watch function and adding a dedicated closure handler. Additionally, transition and class binding adjustments have been made for improved maintainability. New modal configurations are introduced to control the centering and overlay blur effects within the modal examples.

Changes

File(s)	Change Summary
packages/@core/ui-kit/popup-ui/src/alert/alert.ts	Added a new optional numeric property overlayBlur to the AlertProps type with a Chinese comment explaining its use.
packages/@core/ui-kit/popup-ui/src/alert/alert.vue	Removed the watch function for the open state and introduced onAlertClosed for handling closures, added an await nextTick() call in handleOpenChange, updated template bindings for overlay-blur, and simplified layout CSS classes.
packages/@core/ui-kit/shadcn-ui/src/ui/alert-dialog/AlertDialogContent.vue	Modified the <Transition> component to include the appear attribute and refactored class bindings into multiple lines, including conditional classes based on the centered prop.
playground/src/views/examples/modal/index.vue	Updated modal configuration: added centered: false in the openConfirm function and introduced overlayBlur: 3 in the openPrompt function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AlertComponent
    participant nextTick

    User->>AlertComponent: Trigger open/close event
    AlertComponent->>+nextTick: Wait for state update
    nextTick-->>-AlertComponent: Update completed
    AlertComponent->>AlertComponent: Execute onAlertClosed
    AlertComponent->>Parent: Emit 'closed' event with isConfirm value

Loading

sequenceDiagram
    participant User
    participant ModalSystem

    User->>ModalSystem: Open confirmation modal
    ModalSystem->>ModalSystem: Apply config { centered: false }
    ModalSystem->>User: Display confirmation modal

    User->>ModalSystem: Open prompt modal
    ModalSystem->>ModalSystem: Apply config { overlayBlur: 3 }
    ModalSystem->>User: Display prompt modal

Loading

Poem

I’m a rabbit in a code-filled glen,
Hopping through changes now and then.
Overlay blur and modals so neat,
Logic streamlined with a rhythmic beat.
With every commit, I cheer with delight,
“New code is a joy—hop on, it’s light!” 🐇💻

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 36bf6fc and 04efe26.

📒 Files selected for processing (4)

• packages/@core/ui-kit/popup-ui/src/alert/alert.ts (1 hunks)
• packages/@core/ui-kit/popup-ui/src/alert/alert.vue (4 hunks)
• packages/@core/ui-kit/shadcn-ui/src/ui/alert-dialog/AlertDialogContent.vue (2 hunks)
• playground/src/views/examples/modal/index.vue (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Check (windows-latest)
• GitHub Check: Lint (windows-latest)
• GitHub Check: post-update (ubuntu-latest)
• GitHub Check: post-update (windows-latest)

🔇 Additional comments (10)

packages/@core/ui-kit/popup-ui/src/alert/alert.ts (1)

39-42: Good addition of overlayBlur property

This property enhances the alert component by allowing developers to specify a blur effect for the alert's overlay, consistent with modern UI design practices.

playground/src/views/examples/modal/index.vue (2)

141-141: Good use of positioning control with centered: false

Adding this property provides better control over modal positioning, matching the alert animation changes.

---

164-164: Good implementation of blur effect

The overlayBlur: 3 property properly utilizes the newly added overlay blur feature, providing a subtle visual enhancement to the prompt modal.

packages/@core/ui-kit/popup-ui/src/alert/alert.vue (5)

6-6: Improved import organization

The imports are now properly arranged in a single line, making the code more concise.

---

43-46: Good refactoring of alert closing logic

The new onAlertClosed function simplifies the closing logic by directly emitting the closed event with the current value of isConfirm and resetting it. This is cleaner than the previous watch implementation.

---

101-101: Proper use of nextTick for state updates

Adding await nextTick() ensures DOM updates are processed before executing the function logic, which is crucial for proper animation transitions.

---

122-122: Properly connected new features

The addition of :overlay-blur="overlayBlur" binding and the use of onAlertClosed for the @closed event correctly implements the new functionality.

Also applies to: 124-124

---

128-128: Improved class structure

Removing the top-[10vh] positioning from the class string allows for more dynamic positioning controlled by the centered prop, improving the animation behavior.

packages/@core/ui-kit/shadcn-ui/src/ui/alert-dialog/AlertDialogContent.vue (2)

64-64: Fixed transition animation with appear attribute

Adding the appear attribute to the <Transition> component ensures that animations play correctly when the component first renders, addressing the core issue in the PR.

---

83-93: Improved animation structure with conditional classes

The restructured class binding with conditional classes based on the centered prop creates a more maintainable codebase and allows for different slide-in and slide-out animations depending on dialog positioning.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.