fix: add special case for ffmpeg-static
#539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ijjk
approved these changes
Aug 23, 2025
|
🎉 This PR is included in version 0.30.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mischnic
added a commit
to vercel/next.js
that referenced
this pull request
Aug 25, 2025
Include test added by vercel/nft#539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ffmpeg-staticpkg has a lot of dynamic code, especially for install, but we know the public api is to always return the path to the binary. So we can use that in a special case to always emit that binary.