fix(runloop): honor skip confirmations flag

Author: vinhnx

src/agent/runloop/gemini.rs

@@ -25,6 +25,7 @@ use super::tool_output::render_tool_output;
 pub(crate) async fn run_single_agent_loop_gemini(
     config: &CoreAgentConfig,
     vt_cfg: Option<&VTAgentConfig>,
+    skip_confirmations: bool,
 ) -> Result<()> {
     let trim_config = load_context_trim_config(vt_cfg);
     let mut renderer = AnsiRenderer::stdout();
@@ -379,7 +380,8 @@ pub(crate) async fn run_single_agent_loop_gemini(
                         }
 
                         if !modified_files.is_empty()
-                            && confirm_changes_with_git_diff(&modified_files).await?
+                            && confirm_changes_with_git_diff(&modified_files, skip_confirmations)
+                                .await?
                         {
                             renderer.line(MessageStyle::Info, "Changes applied successfully.")?;
                         } else if !modified_files.is_empty() {

src/agent/runloop/git.rs

@@ -11,7 +11,14 @@ fn is_git_repo() -> bool {
         .unwrap_or(false)
 }
 
-pub(crate) async fn confirm_changes_with_git_diff(modified_files: &[String]) -> Result<bool> {
+pub(crate) async fn confirm_changes_with_git_diff(
+    modified_files: &[String],
+    skip_confirmations: bool,
+) -> Result<bool> {
+    if skip_confirmations {
+        return Ok(true);
+    }
+
     if !is_git_repo() {
         println!("Not in a git repository; skipping diff confirmation.");
         return Ok(true);

src/agent/runloop/mod.rs

@@ -12,7 +12,10 @@ mod text_tools;
 mod tool_output;
 mod unified;
 
-pub async fn run_single_agent_loop(config: &CoreAgentConfig) -> Result<()> {
+pub async fn run_single_agent_loop(
+    config: &CoreAgentConfig,
+    skip_confirmations: bool,
+) -> Result<()> {
     let provider = config
         .model
         .parse::<ModelId>()
@@ -24,8 +27,10 @@ pub async fn run_single_agent_loop(config: &CoreAgentConfig) -> Result<()> {
     let vt_cfg = cfg_manager.as_ref().map(|manager| manager.config());
 
     match provider {
-        Provider::Gemini => gemini::run_single_agent_loop_gemini(config, vt_cfg).await,
-        _ => unified::run_single_agent_loop_unified(config, vt_cfg).await,
+        Provider::Gemini => {
+            gemini::run_single_agent_loop_gemini(config, vt_cfg, skip_confirmations).await
+        }
+        _ => unified::run_single_agent_loop_unified(config, vt_cfg, skip_confirmations).await,
     }
 }
 

src/agent/runloop/unified.rs

@@ -24,6 +24,7 @@ use super::tool_output::render_tool_output;
 pub(crate) async fn run_single_agent_loop_unified(
     config: &CoreAgentConfig,
     vt_cfg: Option<&VTAgentConfig>,
+    skip_confirmations: bool,
 ) -> Result<()> {
     let mut renderer = AnsiRenderer::stdout();
     renderer.line(MessageStyle::Info, "Interactive chat (tools)")?;
@@ -345,7 +346,11 @@ pub(crate) async fn run_single_agent_loop_unified(
                             }
 
                             if !modified_files.is_empty()
-                                && confirm_changes_with_git_diff(&modified_files).await?
+                                && confirm_changes_with_git_diff(
+                                    &modified_files,
+                                    skip_confirmations,
+                                )
+                                .await?
                             {
                                 renderer
                                     .line(MessageStyle::Info, "Changes applied successfully.")?;

src/cli/chat_tools.rs

@@ -1,9 +1,6 @@
 use anyhow::Result;
 use vtagent_core::config::types::AgentConfig as CoreAgentConfig;
 
-pub async fn handle_chat_command(
-    config: &CoreAgentConfig,
-    _skip_confirmations: bool,
-) -> Result<()> {
-    crate::agent::runloop::run_single_agent_loop(config).await
+pub async fn handle_chat_command(config: &CoreAgentConfig, skip_confirmations: bool) -> Result<()> {
+    crate::agent::runloop::run_single_agent_loop(config, skip_confirmations).await
 }