fix(plugin-react): respect opts.fastRefresh in viteBabel#5139
Merged
patak-cat merged 1 commit intovitejs:mainfrom Sep 30, 2021
Merged
fix(plugin-react): respect opts.fastRefresh in viteBabel#5139patak-cat merged 1 commit intovitejs:mainfrom
opts.fastRefresh in viteBabel#5139patak-cat merged 1 commit intovitejs:mainfrom
Conversation
Shinigami92
reviewed
Sep 29, 2021
Contributor
Author
|
Updated to use logical OR assignment. Also, the failing test looks like flake to me, but LMK if there's anything else you'd like. |
patak-cat
approved these changes
Sep 30, 2021
opts.fastRefresh in viteBabelopts.fastRefresh in viteBabel
Member
Yes, we are having issues with the tests like last time you were helping. |
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found that the
fastRefreshoption in plugin-react was not entirely preventing fast-refresh from being added to my files, which was causing them to blow up in my testing environment.The change here is to respect the option as well as the existing production / build checks.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).