fix(plugin-react): restore usage of extension instead of id#5761
Merged
antfu merged 1 commit intovitejs:mainfrom Nov 19, 2021
Merged
fix(plugin-react): restore usage of extension instead of id#5761antfu merged 1 commit intovitejs:mainfrom
antfu merged 1 commit intovitejs:mainfrom
Conversation
Member
|
Is this a bug fix or an optimization? 🤔 |
9 tasks
patak-cat
approved these changes
Nov 19, 2021
Member
|
Any chance to add a test for this one? |
antfu
approved these changes
Nov 19, 2021
Contributor
|
Sorry, that slipped by when rebasing an older PR. 😬 Perhaps a test could be added later, but I don't expect this regression to happen again. |
Contributor
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
idparameter could contain a querystring so the extension checks should be done using theextensionvariable. This was the case until it was reverted in #5255 but probably not on purpose (@aleclarson is this correct?)What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).