Merged
Conversation
tony19
reviewed
Aug 26, 2022
|
|
||
| test('deep import with query with exports field', async () => { | ||
| // since it is imported with `?url` it should return a url | ||
| // since it is imported with `?url` it should return an url |
Contributor
There was a problem hiding this comment.
Suggested change
| // since it is imported with `?url` it should return an url | |
| // since it is imported with `?url` it should return a URL |
Similar to issue above with the unsounded h, use a before a sounded u.
playground/wasm/vite.config.ts
Outdated
| export default defineConfig({ | ||
| build: { | ||
| // make can no emit light.wasm | ||
| // make can not emit light.wasm |
Contributor
There was a problem hiding this comment.
Suggested change
| // make can not emit light.wasm | |
| // make cannot emit light.wasm |
| let res: string | undefined | ||
|
|
||
| // if we fould postfix exist, we should first try resolving file with postfix. details see #4703. | ||
| // if we found postfix exist, we should first try resolving file with postfix. details see #4703. |
Contributor
There was a problem hiding this comment.
Suggested change
| // if we found postfix exist, we should first try resolving file with postfix. details see #4703. | |
| // if a postfix exists, we should first try resolving file with postfix. details see #4703. |
packages/vite/src/node/server/ws.ts
Outdated
| const host = (hmr && hmr.host) || undefined | ||
| if (httpsOptions) { | ||
| // if we're serving the middlewares over https, the ws library doesn't support automatically creating an https server, so we need to do it ourselves | ||
| // if we're serving the middlewares over https, the ws library doesn't support automatically creating a https server, so we need to do it ourselves |
Contributor
There was a problem hiding this comment.
Suggested change
| // if we're serving the middlewares over https, the ws library doesn't support automatically creating a https server, so we need to do it ourselves | |
| // if we're serving the middlewares over https, the ws library doesn't support automatically creating an https server, so we need to do it ourselves |
The original text is correct. Use an before an unsounded h.
Contributor
Author
|
@tony19 Thanks for the review, I have fixed all the issues you raised. |
patak-cat
previously approved these changes
Aug 29, 2022
bluwy
reviewed
Aug 29, 2022
bluwy
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).