-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Allow the use of db credentials when verifying unmanaged tablets config #17984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GuptaManan100
merged 1 commit into
vitessio:main
from
planetscale:allow-credentials-file-for-managed-tablets
Mar 19, 2025
Merged
Allow the use of db credentials when verifying unmanaged tablets config #17984
GuptaManan100
merged 1 commit into
vitessio:main
from
planetscale:allow-credentials-file-for-managed-tablets
Mar 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <[email protected]>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17984 +/- ##
==========================================
- Coverage 67.59% 67.58% -0.01%
==========================================
Files 1598 1598
Lines 259983 260050 +67
==========================================
+ Hits 175727 175754 +27
- Misses 84256 84296 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
deepthi
approved these changes
Mar 19, 2025
GuptaManan100
approved these changes
Mar 19, 2025
5 tasks
mhamza15
pushed a commit
to github/vitess-gh
that referenced
this pull request
Aug 22, 2025
…ig (vitessio#17984) Signed-off-by: Florent Poinsard <[email protected]>
3 tasks
mhamza15
pushed a commit
to github/vitess-gh
that referenced
this pull request
Aug 22, 2025
…ig (vitessio#17984) Signed-off-by: Florent Poinsard <[email protected]>
3 tasks
mhamza15
added a commit
to github/vitess-gh
that referenced
this pull request
Aug 22, 2025
…ig (vitessio#17984) (#189) Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>
mhamza15
added a commit
to github/vitess-gh
that referenced
this pull request
Sep 9, 2025
…ig (vitessio#17984) (#190) Signed-off-by: Florent Poinsard <[email protected]> Signed-off-by: Mohamed Hamza <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: VTTablet
Release Blocker: release-22.0
This item blocks the release on branch release-22.0
Type: Bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In planetscale/vitess-operator#671 we are starting to use the
--unmanagedvttablet flag introduced in #14871. CI is showing an interesting failure where vttablet expects a password and user to be set via flags. The operator does set the user (code); but the password is instead stored in a K8SSecretobject, and is passed down to vttablet via the--db-credentials-fileflag.However, with the current implementation, vttablet does not take into account the password stored in
--db-credentials-filewhen verifying the unmanaged tablet settings and fail early since we have not set the--db_app_passwordflag.This PR fixes this issue by making vttablet look at the credentials file before failing the unmanaged verification.