fix: fix default value propagation (#866)

* fix: fix default value propagation

Signed-off-by: Roman Ondráček <mail@romanondracek.cz>

* fix(utils): fix TypeScript errors in parse-vitest-fn-call

Signed-off-by: Roman Ondráček <mail@romanondracek.cz>

* update package-lock yml file

---------

Signed-off-by: Roman Ondráček <mail@romanondracek.cz>
Co-authored-by: Verite Mugabo <mugaboverite@gmail.com>

Author: Roman3349

package.json

@@ -41,15 +41,15 @@
     "update:eslint-docs": "pnpm build && eslint-doc-generator"
   },
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.51.0",
-    "@typescript-eslint/utils": "^8.51.0"
+    "@typescript-eslint/scope-manager": "^8.55.0",
+    "@typescript-eslint/utils": "^8.55.0"
   },
   "devDependencies": {
     "@eslint/js": "^9.38.0",
     "@types/eslint": "^9.6.1",
     "@types/node": "^22.18.10",
-    "@typescript-eslint/parser": "^8.51.0",
-    "@typescript-eslint/rule-tester": "^8.51.0",
+    "@typescript-eslint/parser": "^8.55.0",
+    "@typescript-eslint/rule-tester": "^8.55.0",
     "bumpp": "^10.3.1",
     "concurrently": "^9.2.1",
     "eslint": "^9.37.0",

pnpm-lock.yaml

@@ -54,7 +54,6 @@ export default createEslintRule<[Partial<Options>], MessageIds>({
     ],
     defaultOptions: [{}],
   },
-  defaultOptions: [{}],
   create(context, [options]) {
     return {
       CallExpression(node: TSESTree.CallExpression) {

src/rules/consistent-each-for.ts

@@ -33,23 +33,21 @@ export default createEslintRule<
           pattern: {
             type: 'string',
             format: 'regex',
-            default: defaultPattern.source,
           },
           allTestPattern: {
             type: 'string',
             format: 'regex',
-            default: defaultTestsPattern.source,
           },
         },
       },
     ],
+    defaultOptions: [
+      {
+        pattern: defaultPattern.source,
+        allTestPattern: defaultTestsPattern.source,
+      },
+    ],
   },
-  defaultOptions: [
-    {
-      pattern: defaultPattern.source,
-      allTestPattern: defaultTestsPattern.source,
-    },
-  ],
 
   create: (context, options) => {
     const { pattern: patternRaw, allTestPattern: allTestPatternRaw } =

src/rules/consistent-test-filename.ts

@@ -78,8 +78,8 @@ export default createEslintRule<
         additionalProperties: false,
       },
     ],
+    defaultOptions: [{}],
   },
-  defaultOptions: [{}],
   create(context, options) {
     const { fn, withinDescribe } = options[0]
     const testFnKeyWork = fn || TestCaseName.test

src/rules/consistent-test-it.ts

@@ -29,14 +29,13 @@ export default createEslintRule<[Partial<{ fn: UtilName }>], MESSAGE_ID>({
           fn: {
             type: 'string',
             enum: [UtilName.vi, UtilName.vitest],
-            default: UtilName.vi,
           },
         },
         additionalProperties: false,
       },
     ],
+    defaultOptions: [{ fn: UtilName.vi }],
   },
-  defaultOptions: [{ fn: UtilName.vi }],
   create(context, options) {
     const utilKeyword = options[0].fn!
     const oppositeUtilKeyword = getOppositeVitestUtilKeyword(utilKeyword)

src/rules/consistent-vitest-vi.ts

@@ -49,12 +49,6 @@ export default createEslintRule<Options, MESSAGE_ID>({
       noAssertions: 'Test has no assertions',
     },
   },
-  defaultOptions: [
-    {
-      assertFunctionNames: ['expect', 'assert'],
-      additionalTestBlockFunctions: [],
-    },
-  ],
   create(
     context,
     [{ assertFunctionNames = ['expect'], additionalTestBlockFunctions = [] }],

src/rules/expect-expect.ts

@@ -27,7 +27,6 @@ export default createEslintRule<[], MESSAGE_ID>({
     },
     schema: [],
   },
-  defaultOptions: [],
   create(context) {
     let lastImportEnd: null | number = null
     const nodesToReport: Array<TSESTree.CallExpression> = []