-
Notifications
You must be signed in to change notification settings - Fork 96
[BugFix] Fix qwen3omni thinker batching. #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The account who enabled Codex for this repo no longer has access to Codex. Please contact the admins of this repo to enable Codex again. |
Signed-off-by: yinpeiqi <[email protected]>
Signed-off-by: yinpeiqi <[email protected]>
42bd775 to
593a352
Compare
Gaohan123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Please supplement test plan and test result.
Done. |
Gaohan123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A good catch!
hsliuustc0106
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please add test result
I included a test result (zip file, include output.wav and text txt for three queries) in the pr description. Do I need to to add more result here? |
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
When running multiple prompts, the system raise error if the Qwen3Omni Thinker stage use a batch size > 1.
The reason is, in qwen3 thinker, the program record the
tts_bos_embedas a tensorWhile for the postprocess for multimudal outputs, the program goes into case 1:
However, if the batch size > 1, the program will ignore Case 1, and don't do anything then leave the process.
In my fix plan, I propose:
tts_bos_embedto a list, then the program can go into Case 3.@tzhouam @hsliuustc0106
Test Plan
Configures: set batch size to 3 for both thinker and talker.
Query:
Run bash:
Test Result
Output result: (in .zip)
output_audio.zip
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)