Merge pull request #377 from vormadal/copilot/fix-e2e-not-visible-error

Fix e2e test failures: dialog close timing, day-row click target, attachment upload wait

Author: inur93

anything-frontend/e2e/pages/BillDetailPage.ts

@@ -12,6 +12,24 @@ export class BillDetailPage {
   async uploadAttachment(file: FileInput) {
     const fileInput = this.page.locator('input[type="file"]');
     await fileInput.setInputFiles(file);
+
+    // The upload runs asynchronously after setInputFiles triggers the onChange
+    // handler.  Wait for it to complete: while the upload is in progress the
+    // "Add file" button shows "Uploading..." and is disabled; when it returns to
+    // "Add file" (enabled) the mutation has settled.
+    const uploadingButton = this.page.getByRole("button", {
+      name: "Uploading...",
+    });
+    try {
+      // Wait up to 2 s for the uploading state to appear (it may be very brief)
+      await uploadingButton.waitFor({ state: "visible", timeout: 2_000 });
+    } catch {
+      // Upload may have been instantaneous; continue to the completion wait
+    }
+    // Wait for the button to return to its idle state (upload done or failed)
+    await this.page
+      .getByRole("button", { name: "Add file" })
+      .waitFor({ state: "visible", timeout: 30_000 });
   }
 
   attachmentLink(name: string) {

anything-frontend/e2e/pages/FoodPlanPage.ts

@@ -34,8 +34,14 @@ export class FoodPlanPage {
 
   /**
    * Opens the DayManagementDialog for the first visible day row.
+   *
+   * Clicks the h3 weekday heading rather than the button centre so that the
+   * click lands on the header area even when the day row contains entry-chip
+   * links (<a> elements) from previous test runs.  Clicking the button centre
+   * can inadvertently activate one of those links, navigating away from the
+   * food-plan page instead of opening the dialog.
    */
   async openFirstDayDialog() {
-    await this.dayRows().first().click();
+    await this.dayRows().first().locator("h3").first().click();
   }
 }

anything-frontend/src/components/AddToFoodPlanDialog.tsx

@@ -18,14 +18,17 @@ export function AddToFoodPlanDialog({ recipe, onClose }: AddToFoodPlanDialogProp
 
   const handleSubmit = async () => {
     if (!selectedDate) return;
+    // Close the dialog immediately so the test (and the user) see instant
+    // feedback.  The mutation still runs in the background; any error is
+    // surfaced via a toast notification.
+    onClose();
     try {
       await addEntry.mutateAsync({
         name: recipe.name || "Unnamed Recipe",
         recipeId: recipe.id,
         date: new Date(selectedDate + "T00:00:00Z"),
       });
       toast.success("Added to food plan");
-      onClose();
     } catch {
       toast.error("Failed to add to food plan. Please try again.");
     }