feat: better defaults, cleanup

Author: evenstensberg

lib/utils/compiler.js

@@ -176,7 +176,7 @@ function getCompiler(opts) {
     return webpack(opts.options);
 }
 
-async function webpackInstance(opts, shouldUseMem) {
+async function webpackInstance(opts) {
     const { outputOptions, processingErrors, options } = opts;
 
     if (processingErrors.length > 0) {
@@ -194,7 +194,7 @@ async function webpackInstance(opts, shouldUseMem) {
 
     if (outputOptions.interactive) {
         const interactive = require('./interactive');
-        return interactive(options, outputOptions, processingErrors, shouldUseMem);
+        return interactive(options, outputOptions, processingErrors);
     }
     if (compiler.compilers) {
         compiler.compilers.forEach((comp, idx) => {

lib/utils/development-config.js

@@ -1,9 +1,16 @@
+const { join, resolve } = require('path');
 const TerserPlugin = require('terser-webpack-plugin');
 const JsConfigWebpackPlugin = require('js-config-webpack-plugin');
 
+const defaultOutputPath = resolve(join(process.cwd(), 'dist'));
+
 module.exports = {
     mode: 'development',
     entry: './index.js',
+    output: {
+        path: defaultOutputPath,
+        filename: 'bundle.js'
+    },
     plugins: [new JsConfigWebpackPlugin()],
 
     optimization: {

lib/utils/interactive.js

@@ -102,15 +102,15 @@ const ENTER_KEY = '\n';
 const B_KEY = 'b';
 const C_KEY = 'c';
 
-module.exports = async function(config, outputOptions, processingErrors, shouldUsemem) {
+module.exports = async function(config, outputOptions, processingErrors) {
     const stdin = process.stdin;
     stdin.setEncoding('utf-8');
     stdin.setRawMode(true);
     readline.emitKeypressEvents(stdin);
 
     outputOptions.interactive = false;
 
-    const webpackCompilation = await webpack({ options: config, outputOptions, processingErrors }, shouldUsemem);
+    const webpackCompilation = await webpack({ options: config, outputOptions, processingErrors });
     /* if(errors) {
 	Hngggg
 } */
@@ -163,7 +163,7 @@ module.exports = async function(config, outputOptions, processingErrors, shouldU
                 if (state.length) {
                     state.pop();
                 }
-                const webpackCompilation = await webpack({ options: config, outputOptions, processingErrors }, shouldUsemem);
+                const webpackCompilation = await webpack({ options: config, outputOptions, processingErrors });
                 state.push(webpackCompilation);
                 informActions();
                 isSub = true;

lib/utils/production-config.js

@@ -1,11 +1,17 @@
+const { join, resolve } = require('path');
 const TerserPlugin = require('terser-webpack-plugin');
 const JsConfigWebpackPlugin = require('js-config-webpack-plugin');
 
+const defaultOutputPath = resolve(join(process.cwd(), 'dist'));
+
 module.exports = {
     mode: 'production',
     entry: './index.js',
     plugins: [new JsConfigWebpackPlugin()],
-
+    output: {
+        path: defaultOutputPath,
+        filename: 'bundle.js'
+    },
     optimization: {
         minimizer: [new TerserPlugin()],
     },

lib/webpack-cli.js

@@ -1,4 +1,4 @@
-const { join } = require('path');
+const { resolve, parse, join } = require('path');
 const { existsSync } = require('fs');
 const GroupHelper = require('./utils/group-helper');
 const Compiler = require('./utils/compiler');
@@ -11,7 +11,6 @@ class WebpackCLI extends GroupHelper {
         this.groupMap = new Map();
         this.groups = [];
         this.processingErrors = [];
-        this.shouldUseMem = false;
     }
     setMappedGroups(args, yargsOptions) {
         const { _all } = args;
@@ -32,7 +31,9 @@ class WebpackCLI extends GroupHelper {
     }
 
     checkDefaults(options) {
-        const { resolve, parse } = require('path');
+        if (Array.isArray(options)) {
+            return options.map(opt => this.checkDefaults(opt));
+        }
         const defaultEntry = 'index';
         const possibleFileNames = [
             `./${defaultEntry}`, `./${defaultEntry}.js`, `${defaultEntry}.js`, defaultEntry,
@@ -56,8 +57,6 @@ class WebpackCLI extends GroupHelper {
                 }
 
             }
-        } else if (Array.isArray(options)) {
-            return options.map(opt => this.checkDefaults(opt));
         }
         return options;
     }
@@ -144,7 +143,7 @@ class WebpackCLI extends GroupHelper {
 
     async run(args, yargsOptions) {
         const groupResult = await this.processArgs(args, yargsOptions);
-        const webpack = await Compiler.webpackInstance(groupResult, this.shouldUseMem);
+        const webpack = await Compiler.webpackInstance(groupResult);
         return webpack;
     }