fix: rename sourcemap flag to devtool (#1723)

Author: anshumanv

packages/webpack-cli/README.md

@@ -49,7 +49,7 @@ yarn add webpack-cli --dev
   -w, --watch              Watch for files changes
   -h, --hot                Enables Hot Module Replacement
   --no-hot                 Disables Hot Module Replacement
-  -s, --sourcemap string   Determine source maps to use
+  -d, --devtool string     Controls if and how source maps are generated.
   --prefetch string        Prefetch this request
   -j, --json               Prints result as JSON
   --mode string            Defines the mode to pass to webpack

packages/webpack-cli/lib/groups/BasicGroup.js

@@ -30,9 +30,8 @@ class BasicGroup extends GroupHelper {
             // const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
             // this.opts.options.plugins = [new BundleAnalyzerPlugin()];
             // }
-            if (arg === 'sourcemap') {
-                options.devtool = args[arg] || 'eval';
-                outputOptions.devtool = args[arg];
+            if (arg === 'devtool') {
+                options.devtool = args[arg];
             }
             if (arg === 'entry') {
                 options[arg] = this.resolveFilePath(args[arg], 'index.js');

packages/webpack-cli/lib/utils/cli-flags.js

@@ -33,7 +33,7 @@ let flagsFromCore =
         : [];
 
 // duplicate flags
-const duplicateFlags = ['entry', 'mode', 'stats', 'watch', 'target'];
+const duplicateFlags = ['entry', 'mode', 'stats', 'watch', 'target', 'devtool'];
 
 flagsFromCore = flagsFromCore.filter((flag) => !duplicateFlags.includes(flag.name));
 
@@ -194,10 +194,10 @@ module.exports = {
             link: 'https://webpack.js.org/concepts/hot-module-replacement/',
         },
         {
-            name: 'sourcemap',
-            usage: '--sourcemap <sourcemap | eval>',
+            name: 'devtool',
+            usage: '--devtool <value>',
             type: String,
-            alias: 's',
+            alias: 'd',
             defaultValue: undefined,
             group: BASIC_GROUP,
             description: 'Determine source maps to use',

test/source-map/array/index.js test/devtool/array/index.jstest/source-map/array/index.js renamed to test/devtool/array/index.js

@@ -14,7 +14,7 @@ describe('source-map object', () => {
         });
     });
     it('should override entire array on flag', (done) => {
-        const { stderr } = run(__dirname, ['--sourcemap', 'source-map', '--output', './binary'], false);
+        const { stderr } = run(__dirname, ['--devtool', 'source-map', '--output', './binary'], false);
         expect(stderr).toBe('');
         readdir(resolve(__dirname, 'binary'), (err, files) => {
             expect(err).toBe(null);

…ource-map/array/source-map-array.test.js …t/devtool/array/source-map-array.test.jstest/source-map/array/source-map-array.test.js renamed to test/devtool/array/source-map-array.test.js test/source-map/array/source-map-array.test.js renamed to test/devtool/array/source-map-array.test.js

@@ -24,7 +24,7 @@ describe('source-map object', () => {
     });
 
     it('should override config with source-map', (done) => {
-        run(__dirname, ['-c', './webpack.eval.config.js', '--sourcemap', 'source-map', '-o', './binary/dist-amd.js'], false);
+        run(__dirname, ['-c', './webpack.eval.config.js', '--devtool', 'source-map', '-o', './binary/dist-amd.js'], false);
         stat(resolve(__dirname, 'binary/dist-amd.js.map'), (err, stats) => {
             expect(err).toBe(null);
             expect(stats.isFile()).toBe(true);