Skip to content

Commit ffd35ce

Browse files
authored
Merge branch 'next' into fix/bail-watch-warn
2 parents dbeaeb2 + 1bd9ac9 commit ffd35ce

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

test/core-flags/module-flags.test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ describe('module config related flag', () => {
5757
if (propName === 'use' || propName === 'type') {
5858
expect(stdout).toContain(`${propName}: 'javascript/auto'`);
5959
} else if (property.includes('use-')) {
60+
stdout = run(__dirname, ['--module-rules-use-loader', 'myLoader']).stdout;
6061
expect(stdout).toContain(`use: [Object]`);
6162
} else if (propName === 'enforce') {
6263
stdout = run(__dirname, [`--${flag.name}`, 'pre', '--module-rules-use-loader', 'myLoader']).stdout;

test/core-flags/resolve-flags.test.js

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe('resolve config related flags', () => {
1414
}
1515
const propName = hyphenToUpperCase(property);
1616

17-
if (flag.type === Boolean && !flag.name.includes('alias-')) {
17+
if (flag.type === Boolean && !flag.name.includes('alias-') && !flag.name.includes('fallback-')) {
1818
it(`should config --${flag.name} correctly`, () => {
1919
const { stderr, stdout } = run(__dirname, [`--${flag.name}`]);
2020

@@ -28,7 +28,7 @@ describe('resolve config related flags', () => {
2828
});
2929
}
3030

31-
if (flag.type === String && !flag.name.includes('alias-')) {
31+
if (flag.type === String && !flag.name.includes('alias-') && !flag.name.includes('fallback-')) {
3232
it(`should config --${flag.name} correctly`, () => {
3333
const { stderr, stdout } = run(__dirname, [`--${flag.name}`, 'browser']);
3434
expect(stderr).toBeFalsy();
@@ -40,7 +40,7 @@ describe('resolve config related flags', () => {
4040
});
4141
}
4242

43-
if (flag.name.includes('alias-')) {
43+
if (flag.name.includes('alias-') || flag.name.includes('fallback-')) {
4444
it(`should config --${flag.name} correctly`, () => {
4545
const { stderr, stdout } = run(__dirname, [
4646
`--resolve-alias-alias`,
@@ -55,25 +55,40 @@ describe('resolve config related flags', () => {
5555
'loaderName',
5656
'--resolve-loader-alias-fields',
5757
'loader-field',
58+
'--resolve-fallback-alias',
59+
'fall-alias',
60+
'--resolve-fallback-name',
61+
'fall-name',
62+
'--resolve-loader-fallback-alias',
63+
'loader-fall-alias',
64+
'--resolve-loader-fallback-name',
65+
'loader-fall-name',
5866
]);
5967
expect(stderr).toBeFalsy();
6068
expect(stdout).toContain(`alias: [ { alias: 'alias', name: 'name' } ]`);
6169
expect(stdout).toContain(`aliasFields: [ 'aliasField' ]`);
6270
expect(stdout).toContain(`alias: [ { alias: 'loaderAlias', name: 'loaderName' } ]`);
6371
expect(stdout).toContain(`aliasFields: [ 'loader-field' ]`);
72+
expect(stdout).toContain('fall-name');
73+
expect(stdout).toContain('fall-alias');
74+
expect(stdout).toContain('loader-fall-name');
75+
expect(stdout).toContain('loader-fall-alias');
6476
});
6577

6678
if (flag.name.includes('reset')) {
6779
it(`should config --${flag.name} alias-reset flags correctly`, () => {
6880
const { stderr, stdout } = run(__dirname, [
69-
`--resolve-alias-reset`,
81+
'--resolve-alias-reset',
82+
'--resolve-fallback-reset',
7083
'--resolve-alias-fields-reset',
7184
'--resolve-loader-alias-reset',
7285
'--resolve-loader-alias-fields-reset',
86+
'--resolve-loader-fallback-reset',
7387
]);
7488
expect(stderr).toBeFalsy();
7589
expect(stdout).toContain(`alias: []`);
7690
expect(stdout).toContain(`aliasFields: []`);
91+
expect(stdout).toContain(`fallback: []`);
7792
});
7893
}
7994
}

0 commit comments

Comments
 (0)