chore(bootstrap): refactor code#1037
Merged
ematipico merged 8 commits intowebpack:nextfrom Aug 18, 2019
Merged
Conversation
normalizeFlags method
normalizeFlags method
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
suggested changes
Aug 17, 2019
Contributor
ematipico
left a comment
ematipico
left a comment
There was a problem hiding this comment.
Please revert the isFlagPresent function
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
ematipico
suggested changes
Aug 18, 2019
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
normalizeFlags
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
evenstensberg
approved these changes
Aug 18, 2019
Member
evenstensberg
left a comment
evenstensberg
left a comment
There was a problem hiding this comment.
lgtm, @ematipico needs to sign this off
anshumanv
approved these changes
Aug 18, 2019
rishabh3112
requested changes
Aug 18, 2019
ematipico
approved these changes
Aug 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
N/A
Summary
refactor code
Does this PR introduce a breaking change?
N/A
Other information